Skip to content

Fix postbox widget resizable and draggable binding on window resize #222

Merged
merged 1 commit into from Jan 4, 2016

2 participants

@Graham--M

This pr fixes two issues in the postbox widget's resizePostbox() method.

First, when the postbox collapses into its fixed state at the top of the page and later reverts back to its floating state, the draggable handle widget isn't rebound meaning you cannot move the postbox until you open and close it.

Secondly, if the postbox is collapsed in its closed state, the resizable widget is rebound when the postbox reverts to its floating state meaning that when the postbox is opened, the textarea and resizer widget are much smaller than the rest of the postbox because the resizer widget uses the textarea dimensions when it isn't displayed.

These are fixed by adding a check in the resizePostbox() method to see if the draggable and resizable widgets should be rebound when the postbox reverts to its floating state.

I've tested these changes by modifying the JavaScript served from beta.8ch.net but I haven't had the opportunity to test them in a full Infinity-Next install

@jaw-sh jaw-sh merged commit f663346 into infinity-next:master Jan 4, 2016
@jaw-sh
jaw-sh commented Jan 4, 2016

@Graham--M Haha, this merge was commit number 1000. Cheers.

@Graham--M Graham--M deleted the Graham--M:pr-postbox-fix-160104 branch Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.