Transform step for incomes is making a mistake #14

Closed
zmaril opened this Issue Jul 23, 2014 · 4 comments

Projects

None yet

2 participants

Contributor
zmaril commented Jul 23, 2014

If you compare the original copy of this document to the transformed data, it seems that there is a mistake in how the various fields related to expense are calculated. Specifically, the expense_less_than_five_thousand field is false, implying that the expense is greater than 5000, while the expense_amount field is null. In the original document, neither field was check and expenses was left blank, which seems to imply that there were no expenses (rather than implying there was an unknown expense that was greater than 5000).

Contributor

yeah, looks like there's some problem with the boolean checkbox parser.

@boblannon boblannon self-assigned this Jul 24, 2014
@boblannon boblannon added this to the full sopr D + ETL milestone Jul 24, 2014
Contributor

Okay, I see the issue. The filer just left the expenses field completely blank, which isn't a case I'd planned for. For both income and expense, if both of these boxes are unchecked, the value of expense_less_than_five_thousand should probably just be null.

screenshot from 2014-07-24 10 33 14

Contributor
zmaril commented Jul 24, 2014

Makes sense to me.

Contributor

fixed in deee6ef

@boblannon boblannon closed this Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment