There are several fields that are common to both the reports and registrations forms that are expressed in different ways in each. Calling the fields the same thing in both instances would make working with the files much easier to understand and program against. Besides the following three fields, everything else matches up as well as it can and is easy to work with:
the registrant_house_id and the client_registrant_house_id are different things, so shouldn't have the same field name. per the LDA guide:
What they refer to as "Complete Senate ID" is the value of the field that we get in LD-2's. In the future, if it seems like that field is actually sane, we can split it and assign the client and registrant IDs separately.
You're right about report_is_amendment. There should be a separate "report type" subtree.
Also, registrant.registrant_contact_name in reports versus registrant.registrant_contact in registrations. Same for similar fields dealing with email and phones for contacts.
lobbyist_covered_official_position vs. :lobbyist_covered_position
standardizing general_issue_area fixes #15
other related commits: