New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw query editor for kapacitor #789

Closed
adityacs opened this Issue Jan 23, 2017 · 19 comments

Comments

@adityacs

adityacs commented Jan 23, 2017

I don't see the following features in chronograf currently. Adding this would be very helpful.

  1. Raw query editor for writing Kapacitor scripts.
  2. UI for writing script to take action on alert. ".exec" integration.

Thanks

@nhaugo

This comment has been minimized.

Show comment
Hide comment
@nhaugo

nhaugo Jan 24, 2017

Contributor

Hi @adityacs 2) should be handled with #782. We have plans for a raw query editor, but I don't think there is a proper ticket yet. I am editing 2) out of the title and I will use this issue as a starting point for 1).

Contributor

nhaugo commented Jan 24, 2017

Hi @adityacs 2) should be handled with #782. We have plans for a raw query editor, but I don't think there is a proper ticket yet. I am editing 2) out of the title and I will use this issue as a starting point for 1).

@nhaugo nhaugo changed the title from Raw query editor for kapacitor and UI for writing script to execute on alert to Raw query editor for kapacitor Jan 24, 2017

@nhaugo nhaugo added this to the 1.2.0-beta-x milestone Jan 24, 2017

@adityacs

This comment has been minimized.

Show comment
Hide comment
@adityacs

adityacs commented Jan 24, 2017

@nhaugo Thanks

@alexpaxton

This comment has been minimized.

Show comment
Hide comment
@alexpaxton

alexpaxton Jan 25, 2017

Member

@adityacs Hey I am working on the design of Chronograf, wondering if you would be willing to hop on a google hangout and I could pick your brain about the Kapacitor Raw Editor idea?

Member

alexpaxton commented Jan 25, 2017

@adityacs Hey I am working on the design of Chronograf, wondering if you would be willing to hop on a google hangout and I could pick your brain about the Kapacitor Raw Editor idea?

@adityacs

This comment has been minimized.

Show comment
Hide comment
@adityacs

adityacs Jan 27, 2017

@alexpaxton Let me know what time is suitable for you. I can join

adityacs commented Jan 27, 2017

@alexpaxton Let me know what time is suitable for you. I can join

@goller goller added the kapacitor label Jan 30, 2017

@allen13

This comment has been minimized.

Show comment
Hide comment
@allen13

allen13 Feb 6, 2017

+1 on raw query editor. Also, It would be great if you could just straight up edit/manage tick scripts in chronograph via a dumb text editor. Tick scripts are so expressive that it would be difficult to create a UI that maps to all of the features.

allen13 commented Feb 6, 2017

+1 on raw query editor. Also, It would be great if you could just straight up edit/manage tick scripts in chronograph via a dumb text editor. Tick scripts are so expressive that it would be difficult to create a UI that maps to all of the features.

@goller

This comment has been minimized.

Show comment
Hide comment
@goller

goller Feb 6, 2017

Contributor

@allen13 you are totally right. TICKscripts are really expressive. @alexpaxton has been working on a raw editor. @allen13, what sorts of features would you like in that type of editor? I'm thinking at least it would "validate" the TICKscript before sending it to kapacitor.

Contributor

goller commented Feb 6, 2017

@allen13 you are totally right. TICKscripts are really expressive. @alexpaxton has been working on a raw editor. @allen13, what sorts of features would you like in that type of editor? I'm thinking at least it would "validate" the TICKscript before sending it to kapacitor.

@allen13

This comment has been minimized.

Show comment
Hide comment
@allen13

allen13 Feb 6, 2017

All I need is <textarea></textarea>. Anything else is just icing on the cake. Validation and syntax highlighting would be at the top of my list after that.

allen13 commented Feb 6, 2017

All I need is <textarea></textarea>. Anything else is just icing on the cake. Validation and syntax highlighting would be at the top of my list after that.

@adityacs

This comment has been minimized.

Show comment
Hide comment
@adityacs

adityacs Feb 7, 2017

+1 for @allen13 idea. Currently we can't write queries like this "select 100 - mean($x) + mean($y)". A simple editor should allow me to do this. Also, adding validation to this would be good feature.

adityacs commented Feb 7, 2017

+1 for @allen13 idea. Currently we can't write queries like this "select 100 - mean($x) + mean($y)". A simple editor should allow me to do this. Also, adding validation to this would be good feature.

@smetroid

This comment has been minimized.

Show comment
Hide comment
@smetroid

smetroid Feb 7, 2017

+1 for validation

smetroid commented Feb 7, 2017

+1 for validation

@allen13

This comment has been minimized.

Show comment
Hide comment
@allen13

allen13 Feb 8, 2017

@alyan2008 Wouldn't it be better if we focused our efforts on Chronograph? The react code powering it is pretty straightforward to work with and all of the groundwork for a kapacitor ui has been done. I do understand that you may have custom needs though.

allen13 commented Feb 8, 2017

@alyan2008 Wouldn't it be better if we focused our efforts on Chronograph? The react code powering it is pretty straightforward to work with and all of the groundwork for a kapacitor ui has been done. I do understand that you may have custom needs though.

@goller

This comment has been minimized.

Show comment
Hide comment
@goller

goller Feb 9, 2017

Contributor

@alyan2008 @allen13 I'm hoping we'll do this in our next sprint, although, I suspect we'll be working on our dashboard solution.

However, if you wanted to help contribute this feature that would be awesome!

Contributor

goller commented Feb 9, 2017

@alyan2008 @allen13 I'm hoping we'll do this in our next sprint, although, I suspect we'll be working on our dashboard solution.

However, if you wanted to help contribute this feature that would be awesome!

@mpchadwick

This comment has been minimized.

Show comment
Hide comment
@mpchadwick

mpchadwick May 25, 2017

Contributor

However, if you wanted to help contribute this feature that would be awesome!

Does this statement still hold? This is would be a meaty one to take on, but I'm somewhat interested in contributing this (if I can find the time). Don't want to step on someone's toes if this is already in flight.

Contributor

mpchadwick commented May 25, 2017

However, if you wanted to help contribute this feature that would be awesome!

Does this statement still hold? This is would be a meaty one to take on, but I'm somewhat interested in contributing this (if I can find the time). Don't want to step on someone's toes if this is already in flight.

@goller

This comment has been minimized.

Show comment
Hide comment
@goller

goller May 25, 2017

Contributor

Hey @mpchadwick , it's not yet in flight, no. We'd love that kind of contribution!

In the broadest outline the chronograf server's Generate function would need to either use the QueryConfig structure or if it is nil use TICKScript (https://github.com/influxdata/chronograf/blob/master/chronograf.go#L236-L237 & https://github.com/influxdata/chronograf/blob/master/kapacitor/tickscripts.go#L15)

For the javascript, we'd need a new component that edited the raw tick script. Here is where tickscripts without queries are handled today: https://github.com/influxdata/chronograf/blob/master/ui/src/kapacitor/components/KapacitorRulesTable.js#L64

Contributor

goller commented May 25, 2017

Hey @mpchadwick , it's not yet in flight, no. We'd love that kind of contribution!

In the broadest outline the chronograf server's Generate function would need to either use the QueryConfig structure or if it is nil use TICKScript (https://github.com/influxdata/chronograf/blob/master/chronograf.go#L236-L237 & https://github.com/influxdata/chronograf/blob/master/kapacitor/tickscripts.go#L15)

For the javascript, we'd need a new component that edited the raw tick script. Here is where tickscripts without queries are handled today: https://github.com/influxdata/chronograf/blob/master/ui/src/kapacitor/components/KapacitorRulesTable.js#L64

@jaredscheib

This comment has been minimized.

Show comment
Hide comment
@jaredscheib

jaredscheib May 25, 2017

Contributor

@mpchadwick It'd be awesome if you want to take this on. You might refer to #1537 (once it's approved, finalized, and merged) for how this could be implemented.

Contributor

jaredscheib commented May 25, 2017

@mpchadwick It'd be awesome if you want to take this on. You might refer to #1537 (once it's approved, finalized, and merged) for how this could be implemented.

@alexpaxton

This comment has been minimized.

Show comment
Hide comment
@alexpaxton

alexpaxton May 25, 2017

Member

@mpchadwick I have a UI design for this feature put together already, I can walk you through it via hangout or screenshare

Member

alexpaxton commented May 25, 2017

@mpchadwick I have a UI design for this feature put together already, I can walk you through it via hangout or screenshare

@mpchadwick

This comment has been minimized.

Show comment
Hide comment
@mpchadwick

mpchadwick May 26, 2017

Contributor

@alexpaxton is it in a form that would allow upload to this issue? not sure when I can schedule a screenshare, but if you have PDF of something i can try to start from that.

Contributor

mpchadwick commented May 26, 2017

@alexpaxton is it in a form that would allow upload to this issue? not sure when I can schedule a screenshare, but if you have PDF of something i can try to start from that.

@adityacs

This comment has been minimized.

Show comment
Hide comment
@adityacs

adityacs Jun 27, 2017

This feature is an urgent requirement for us. How early can we expect this to be done?

adityacs commented Jun 27, 2017

This feature is an urgent requirement for us. How early can we expect this to be done?

@nhaugo nhaugo modified the milestones: 1.3.5, Uncommitted Jun 27, 2017

@nhaugo nhaugo added the design label Jun 27, 2017

@nhaugo nhaugo modified the milestones: 1.3.6, 1.3.5 Jul 25, 2017

@121watts 121watts added the blocked label Jul 31, 2017

@nhaugo nhaugo modified the milestones: 1.3.7, 1.3.6 Aug 7, 2017

@lukevmorris lukevmorris modified the milestones: 1.3.x, 1.3.7 Aug 15, 2017

@nhaugo nhaugo modified the milestones: 1.3.8, 1.3.x, 1.3.9 Aug 23, 2017

@nhaugo nhaugo added ready and removed in progress labels Aug 29, 2017

@121watts 121watts added in progress and removed ready labels Sep 7, 2017

@goller goller self-assigned this Sep 7, 2017

@goller goller added ready for review and removed in progress labels Sep 7, 2017

@nhaugo nhaugo added delivered and removed ready for review labels Sep 27, 2017

@nhaugo nhaugo closed this Sep 27, 2017

@nhaugo nhaugo removed the delivered label Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment