Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kapa kafka alert node #3386

Merged
merged 24 commits into from May 11, 2018
Merged

Conversation

jaredscheib
Copy link
Contributor

@jaredscheib jaredscheib commented May 5, 2018

Closes #2904
Closes #3385
Closes #3384
Closes #3382

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • Update swagger.json

TODO:

  • fix kafka alert endpoint retention in rule builder
  • ensure field kafka-topic is correct on alert handler
  • update swagger

The Problem

  • Kafka will be introduced as a node type in Kapacitor 1.5, and we want to include support for it in Chronograf.
  • Not all Kapa config errors were being passed through in the error notification successfully.
  • Parts of the MeasurementList and all of the FieldList components in the Kapacitor rule builder DataSection were disabled.

The Solution

  • Introduce a Kafka config & alert handler.
  • Pass through errors successfully, regardless of how many colons they have in the string.
  • Fix & refine the logic that governs when MeasurementList and FieldList are disabled.

This PR also converts DataSection to TypeScript, as well as many of its dependencies.

@jaredscheib jaredscheib force-pushed the feature/kapa_kafka_alert_node branch from 35eaf0d to ad23d12 Compare May 5, 2018 02:06
@jaredscheib jaredscheib force-pushed the feature/kapa_kafka_alert_node branch from c48a658 to d0cf173 Compare May 5, 2018 02:21
@jaredscheib jaredscheib force-pushed the feature/kapa_kafka_alert_node branch from d0cf173 to 98f8f11 Compare May 5, 2018 02:22
@jaredscheib jaredscheib force-pushed the feature/kapa_kafka_alert_node branch from 639c368 to cf71bc9 Compare May 9, 2018 01:54
Convert queryActions & queryTransitions to TS
Fix tests
@jaredscheib jaredscheib force-pushed the feature/kapa_kafka_alert_node branch 2 times, most recently from a689d88 to f1f0dd5 Compare May 9, 2018 22:24
@jaredscheib jaredscheib force-pushed the feature/kapa_kafka_alert_node branch from f1f0dd5 to 42beb1a Compare May 9, 2018 23:32
@ebb-tide ebb-tide self-requested a review May 10, 2018 20:31
@jaredscheib jaredscheib merged commit 15cef57 into master May 11, 2018
@jaredscheib jaredscheib deleted the feature/kapa_kafka_alert_node branch May 11, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants