New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs page spinner #4715

Merged
merged 5 commits into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@OfTheDelmer
Contributor

OfTheDelmer commented Nov 2, 2018

Closes influxdata/applications-team-issues#235

Briefly describe your proposed changes:
Render a page spinner as sources are being fetched
What was the problem?
The logs page was visible but not responsive
What was the solution?
Add a page spinner as sources are being fetched.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass

OfTheDelmer added some commits Nov 2, 2018

@jaredscheib

Looks good to me! Just one Q below. Nice work!

@@ -946,6 +958,16 @@ class LogsPage extends Component<Props, State> {
})
}
private getSources = async (): Promise<void> => {
try {
this.loadingSources = RemoteDataState.Loading

This comment has been minimized.

@jaredscheib

jaredscheib Nov 2, 2018

Contributor

what do you think about loadingSourcesStatus?

This comment has been minimized.

@OfTheDelmer

OfTheDelmer Nov 2, 2018

Contributor

sgtm! makes it clear we are working with a status.

@OfTheDelmer OfTheDelmer merged commit 7974ed3 into master Nov 5, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@OfTheDelmer OfTheDelmer deleted the feat/logs-page-spinner branch Nov 5, 2018

mavarius added a commit that referenced this pull request Nov 5, 2018

Add logs page spinner (#4715)
feat(logs/ui): Add logs page loading spinner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment