Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the ability to specify the org and the bucket when creating the client #97

Merged
merged 9 commits into from Mar 24, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Mar 23, 2020

Closes #96

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar added enhancement New feature or request documentation Documentation change labels Mar 23, 2020
@bednar bednar added this to the 1.7.0 milestone Mar 23, 2020
@codecov-io
Copy link

codecov-io commented Mar 23, 2020

Codecov Report

Merging #97 into master will decrease coverage by 0.75%.
The diff coverage is 62.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #97      +/-   ##
============================================
- Coverage     90.49%   89.73%   -0.76%     
  Complexity      429      429              
============================================
  Files           136      136              
  Lines          5281     5380      +99     
  Branches        204      214      +10     
============================================
+ Hits           4779     4828      +49     
- Misses          422      461      +39     
- Partials         80       91      +11
Impacted Files Coverage Δ Complexity Δ
...uxdb/client/scala/internal/QueryScalaApiImpl.scala 97.18% <100%> (+7.89%) 0 <0> (ø) ⬇️
...client/reactive/InfluxDBClientReactiveFactory.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...client/kotlin/internal/InfluxDBClientKotlinImpl.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
.../reactive/internal/InfluxDBClientReactiveImpl.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...lient/scala/internal/InfluxDBClientScalaImpl.scala 100% <100%> (ø) 0 <0> (ø) ⬇️
...uxdb/client/scala/InfluxDBClientScalaFactory.scala 81.48% <100%> (+3.22%) 0 <0> (ø) ⬇️
...client/reactive/internal/QueryReactiveApiImpl.java 76% <30%> (-16.99%) 0 <0> (ø)
...luxdb/client/kotlin/internal/QueryKotlinApiImpl.kt 76.11% <53.33%> (+2.53%) 0 <0> (ø) ⬇️
...client/reactive/internal/WriteReactiveApiImpl.java 67.01% <55.55%> (-32.99%) 0 <0> (ø)
...ava/com/influxdb/client/InfluxDBClientFactory.java 97.43% <75%> (-2.57%) 0 <0> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63e0d6...3186fec. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to specify the organization when creating the client
2 participants