Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional connection timeout to HTTP API configuration #231

Closed
pauldix opened this issue Feb 4, 2014 · 6 comments

Comments

Projects
None yet
6 participants
@pauldix
Copy link
Member

commented Feb 4, 2014

It seems many client libraries keep their connections open. We might want to have a connection timeout in the config to make sure that these connections end up going away.

@jvshahid jvshahid modified the milestones: 0.7.0, 0.6.0 May 2, 2014

@jvshahid jvshahid modified the milestones: Future release, 0.7.0 May 20, 2014

@jvshahid jvshahid removed this from the Future release milestone Aug 25, 2014

@jvshahid

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2014

@pauldix what's wrong with keeping those connections around if the user doesn't want to close and reopen connections

@toddboom

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2014

@pauldix

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2014

The main problem is that from the browser, keep alives go through and you end up opening a ton of connections and hitting the file limit. I wanted this just from a practical standpoint. However, this bug is moot since it's already been done: https://github.com/influxdb/influxdb/blob/master/config.sample.toml#L36

@toddboom toddboom added api and removed api labels Nov 25, 2014

@aviau

This comment has been minimized.

Copy link
Member

commented Mar 19, 2015

Timeout configuration can help with issues like influxdata/influxdb-python#103 where there are issues with reporting at 5 seconds intervals if the timeout of the server is also 5 seconds.

@beckettsean beckettsean added RFC and removed api need more info labels Apr 8, 2015

@beckettsean beckettsean added this to the Next Point Release milestone Apr 8, 2015

@beckettsean beckettsean modified the milestones: Next Point Release, Longer term Aug 6, 2015

@jsternberg

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2016

@pauldix is this something we should still do?

@jsternberg jsternberg removed this from the Longer term milestone May 17, 2016

@jsternberg

This comment has been minimized.

Copy link
Contributor

commented May 17, 2016

I think we're going to leave this for clients to take care of for now. Due to the possibility of a client reusing connections when writing (not currently possible when querying), I don't think we should set a timeout. We also have #6559 for enforcing a connection limit to ensure that the server doesn't open too many ports.

Closing due to inactivity.

@jsternberg jsternberg closed this May 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.