Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example config with UDP precision option #10051

Merged
merged 1 commit into from Jul 10, 2018
Merged

Conversation

gunnaraasen
Copy link
Member

Required for all non-trivial PRs
  • Sign CLA (if not already signed)
  • Config changes: update sample config (etc/config.sample.toml), server NewDemoConfig method, and Diagnostics methods reporting config settings, if necessary

This updates the config and diagnostic info for the UDP service to include the precision option, which was added in PR #5565.

@rbetts
Copy link
Contributor

rbetts commented Jul 9, 2018

Before we merge this documentation change, it looks like the original PR didn't include a testcase. Also, we need to review this for Enterprise in case this is a configuration stanza that needs to be updated in both places.

@mark-rushakoff
Copy link
Contributor

Yep, looks like services/udp/service_test.go still hasn't been updated with a precision test case since that original PR. This PR so far looks good, but +1 to adding a test case.

Also add a test for precision in the UDP configuration.
@gunnaraasen
Copy link
Member Author

Enterprise already has precision documented in the sample config file. I think not including it here was an oversight.

I've updated the text to reflect the Enterprise config snippet and also added precision to the UDP config test.

@rbetts rbetts requested review from rbetts and removed request for jsternberg July 10, 2018 12:33
Copy link
Contributor

@rbetts rbetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants