Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify s[:] to s where s is a slice #10332

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Conversation

ludweeg
Copy link

@ludweeg ludweeg commented Oct 4, 2018

No description provided.

@ghost ghost added the proposed label Oct 4, 2018
@mark-rushakoff mark-rushakoff changed the base branch from master to 1.8 January 11, 2019 19:02
@e-dard e-dard requested a review from zeebo February 1, 2019 15:56
@e-dard
Copy link
Contributor

e-dard commented Feb 1, 2019

@zeebo can you take a look please.

@e-dard e-dard added the community-pr Pull requests from the community. Thank you! label Feb 1, 2019
@e-dard
Copy link
Contributor

e-dard commented Feb 4, 2019

@ludweeg Thanks for the PR. Could you please sign the CLA. We can't merge this until the CLA is agreed to.

e-dard
e-dard previously requested changes Feb 4, 2019
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting CLA agreement.

@e-dard
Copy link
Contributor

e-dard commented Feb 11, 2019

CLA agreement signed.

@e-dard e-dard dismissed their stale review February 11, 2019 10:24

CLA signed

@e-dard e-dard merged commit 05e7def into influxdata:1.8 Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-pr Pull requests from the community. Thank you! proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants