fix(ui): Make TextAreas the proper size #15634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
commented
Oct 29, 2019
| @@ -23,6 +23,7 @@ module.exports = { | |||
| resolve: { | |||
| alias: { | |||
| src: path.resolve(__dirname, 'src'), | |||
| react: path.resolve('./node_modules/react'), | |||
There was a problem hiding this comment.
this'll let us do things like yarn add ../../clockface/dist/influxdata-clockface-1.0.3.tgz. to test local library builds in chrono 2
There was a problem hiding this comment.
could you flesh out an example of this.. ? I was always npm linking clockface and giraffe. I should share how to do that with people now that I think about it.
ghost
requested review from
121watts and
ebb-tide
and removed request for
a team
ebb-tide
approved these changes
Oct 29, 2019
| @@ -23,6 +23,7 @@ module.exports = { | |||
| resolve: { | |||
| alias: { | |||
| src: path.resolve(__dirname, 'src'), | |||
| react: path.resolve('./node_modules/react'), | |||
There was a problem hiding this comment.
could you flesh out an example of this.. ? I was always npm linking clockface and giraffe. I should share how to do that with people now that I think about it.
hoorayimhelping
force-pushed
the
bs_fix_squished_textareas
branch
from
6d4a8c0
to
6af5c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15499
Apply clockface 1.0.3 to fix TextAreas.