Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): add cell properties to dashboard response #16057

Merged
merged 5 commits into from Dec 3, 2019

Conversation

@dearyhud
Copy link
Member

dearyhud commented Nov 27, 2019

Closes #16052

Describe your proposed changes here.
Adds an optional ?include=properties query string to GET /dashboards/:dashboardID that returns each cells properties

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)
@dearyhud dearyhud requested a review from jademcgough Nov 27, 2019
http/dashboard_service.go Outdated Show resolved Hide resolved
Copy link
Contributor

jademcgough left a comment

Need to add the new param to our swagger :)

@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from f6e6a7b to e09f09b Nov 29, 2019
@dearyhud dearyhud requested review from influxdata/api as code owners Nov 29, 2019
http/dashboard_service.go Outdated Show resolved Hide resolved
http/swagger.yml Show resolved Hide resolved
http/swagger.yml Show resolved Hide resolved
Copy link
Contributor

ebb-tide left a comment

This is awesome !! Thanks for doing this!

@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from 6ae4dbb to 1a9fe28 Dec 2, 2019
@dearyhud dearyhud changed the title feat: adds properties to each cell on GET /dashboards/:dashboardID feat(http): cell properties to GET /dashboards/:dashboardID Dec 2, 2019
@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from 1779159 to 6aaefe9 Dec 2, 2019
@dearyhud dearyhud changed the title feat(http): cell properties to GET /dashboards/:dashboardID feat(http): add cell properties to dashboard response Dec 2, 2019
@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from 6aaefe9 to e237b3d Dec 2, 2019
@dearyhud dearyhud requested review from ebb-tide, jademcgough and jsteenb2 Dec 2, 2019
@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from e237b3d to b36a926 Dec 3, 2019
Copy link
Contributor

jsteenb2 left a comment

lets give it a try

@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from b36a926 to 9eff6b9 Dec 3, 2019
@dearyhud dearyhud merged commit e21ebeb into master Dec 3, 2019
9 checks passed
9 checks passed
Semantic Pull Request ready to be merged, squashed or rebased
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: gotest Your tests passed on CircleCI!
Details
ci/circleci: jstest Your tests passed on CircleCI!
Details
ci/circleci: litmus_daily Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/branch This commit looks good
Details
@dearyhud dearyhud deleted the 15898/dashboard-api-tweaks branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.