Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(timeFormat-single-stat-graph): fixed issue where setting the timeFormat on single-state + graph wasn't persisted #18066

Merged
merged 2 commits into from
May 12, 2020
Merged

fix(timeFormat-single-stat-graph): fixed issue where setting the timeFormat on single-state + graph wasn't persisted #18066

merged 2 commits into from
May 12, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented May 12, 2020 •
edited
Loading

Closes #18033

Problem

timeFormat selections were not persisted for Graph + Single-Stat

Solution

Updated the struct and yml file to correctly return timeFormat when it is included in the patch / get

timeFormat-single-line

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)

@asalem1 asalem1 requested a review from a team May 12, 2020 20:26
@asalem1 asalem1 requested a review from a team as a code owner May 12, 2020 20:26
@asalem1 asalem1 requested review from TCL735 and removed request for a team May 12, 2020 20:26
@asalem1 asalem1 force-pushed the fix/single-stat-timeFormat branch from 6577751 to b4fc4eb Compare May 12, 2020 20:28
@asalem1 asalem1 requested review from a team and jsteenb2 and removed request for a team May 12, 2020 20:30
@asalem1 asalem1 merged commit bf21cf8 into master May 12, 2020
@asalem1 asalem1 deleted the fix/single-stat-timeFormat branch May 12, 2020 21:51
@asalem1 asalem1 mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCL735 TCL735 TCL735 approved these changes

@jsteenb2 jsteenb2 Awaiting requested review from jsteenb2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date formats have stopped working
2 participants
@asalem1 @TCL735