fix: non-idempotent object store deletes#26839
Merged
Merged
Conversation
* Add object store retries via `RetryableObjectStore`
- This is an extension trait, which is needed since we want to provide an
opt-in approach to retries that takes parameters not supported by the
`ObjectStore` trait methods themselves (ie retry params, context string for
error notifications).
- Supports idempotent object store deletes by ignoring `NotFound` errors.
* Add object store failure injection via `TestObjectStore`
- This is a wrapper implementation of `ObjectStore`.
- It gives us various ways of injecting errors in tests (periodic, one time,
percentage-based, etc).
- It gives us the ability to count and assert on actual calls made.
* Validate `RetryableObjectStore` using `TestObjectStore`.
hiltontj
approved these changes
Sep 25, 2025
hiltontj
left a comment
hiltontj
left a comment
Contributor
There was a problem hiding this comment.
Need to fix the 📎 error but otherwise LGTM
waynr
force-pushed
the
fix/non-idempotent-object-store-deletes
branch
from
September 25, 2025 19:26
568143c to
4e8e0a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an idempotency issue in
TableIndexCacheobject deletion retries, where deletes were retried repeatedly even if the error encountered isNotFound, which should be gracefully ignored when a delete is attempted.To do this, I've cherry-picked a new crate from the enterprise fork called
object_store_utils, which includes an extension trait calledRetryableObjectStorethat encodes ignoringNotFounderrors into its deletion methods as a matter of convention.