Allow setting the node id in the influx cli program #9184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jsternberg
force-pushed
the
js-influx-node-id-option
branch
from
f82a53d
to
3268389
Compare
jsternberg
force-pushed
the
js-influx-node-id-option
branch
from
3268389
to
c185704
Compare
There was a problem hiding this comment.
The code change LGTM. @rbetts is this change okay for the OSS CLI?
The string `node <n>` can be used to specify which data node the data should be retrieved from. This uses the `node_id=X` query parameter that is supported, but wasn't exposed anywhere in the client library. We use this feature enough internally when attempting to find inconsistencies or network errors that it is easier if this is just supported. Otherwise, I continue having to recompile the CLI program every time I need to do this. To clear a previously set node, you can use `node 0` or `node clear`.
jsternberg
force-pushed
the
js-influx-node-id-option
branch
from
c185704
to
af23897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string
node <n>can be used to specify which data node the datashould be retrieved from. This uses the
node_id=Xquery parameter thatis supported, but wasn't exposed anywhere in the client library.
We use this feature enough internally when attempting to find
inconsistencies or network errors that it is easier if this is just
supported. Otherwise, I continue having to recompile the CLI program
every time I need to do this.
To clear a previously set node, you can use
node 0ornode clear.