New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui/logs): time point selection dropdown #1361

Merged
merged 5 commits into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@OfTheDelmer
Contributor

OfTheDelmer commented Nov 13, 2018

Closes #influxdata/applications-team-issues#177

Briefly describe your proposed changes:
These changes just update the point in time dropdown to use clockface and additional changes will follow to actually add selected time ranges to the redux state.
What was the problem?
The styling for the custom time selection needed to be ported and the dropdown needed to be updated to use a clockface dropdown. However, clicking on the open calender was also considered outside the clockface dropdown causing it to close when a time was being selected.
What was the solution?

  • port over the styles for the custom time point selector

  • portal the custom time overlay as a child of the the clockface dropdown so clicks would appear to be internal to the clockface dropdown

    • Rebased/mergeable
    • Tests pass

OfTheDelmer added some commits Nov 13, 2018

}
private handleCloseCustomTime = () => {
this.setState({isTimeSelectorOpen: false})
}
private handleOpenCustomTime = () => {
private handleOpenCustomTime = e => {

This comment has been minimized.

@OfTheDelmer

OfTheDelmer Nov 13, 2018

Contributor

Prevent clicking date picker from closing the dropdown with no custom time actually applied.

@jaredscheib

Seems good to me! Cool to see the portal work in action.

@OfTheDelmer OfTheDelmer merged commit fc4986f into master Nov 14, 2018

3 checks passed

ci/circleci: gotest Your tests passed on CircleCI!
Details
ci/circleci: jstest Your tests passed on CircleCI!
Details
continuous-integration/jenkins/branch This commit looks good
Details

@OfTheDelmer OfTheDelmer deleted the fix/logs-timepoint-dropdown branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment