New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a dropdown filter to filter tasks through Organizations #1419

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
4 participants
@Palakp41
Contributor

Palakp41 commented Nov 15, 2018

Co-authored-by: Palak Bhojani palak@influxdata.com
Co-authored-by: Deniz Kusefoglu deniz@influxdata.com

Closes #1372

_What was the solution?_Created a dropdown on Task Header to show all organizations and an ability to filter tasks using the dropdown

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • swagger.json updated (if modified Go structs or API)
  • Sign CLA (if not already signed)
@chnn

chnn approved these changes Nov 15, 2018

looks good, just one suggestion

Show resolved Hide resolved ui/src/tasks/components/TasksHeader.tsx Outdated
Show resolved Hide resolved ui/src/tasks/containers/TasksPage.tsx
@jaredscheib

Generally looks great to me -- nice work @Palakp41!

Show resolved Hide resolved ui/src/tasks/components/TasksOrgDropdown.tsx Outdated
Show resolved Hide resolved ui/src/tasks/components/TasksOrgDropdown.tsx Outdated
Show resolved Hide resolved ui/src/tasks/constants/index.ts Outdated

@Palakp41 Palakp41 force-pushed the feat/tasks-org-dropdown-filter branch from 3081f81 to 14d6944 Nov 15, 2018

Create a dropdown filter to filter tasks through Organizations
Co-authored-by: Palak Bhojani <palak@influxdata.com>
Co-authored-by: Deniz Kusefoglu <deniz@influxdata.com>

@Palakp41 Palakp41 force-pushed the feat/tasks-org-dropdown-filter branch from 14d6944 to b798e55 Nov 15, 2018

@Palakp41 Palakp41 merged commit bf34ece into master Nov 15, 2018

3 checks passed

ci/circleci: gotest Your tests passed on CircleCI!
Details
ci/circleci: jstest Your tests passed on CircleCI!
Details
continuous-integration/jenkins/branch This commit looks good
Details

@Palakp41 Palakp41 deleted the feat/tasks-org-dropdown-filter branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment