Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datadog output plugin logs API key #3419

Closed
bobmshannon opened this issue Nov 2, 2017 · 0 comments
Closed

Datadog output plugin logs API key #3419

bobmshannon opened this issue Nov 2, 2017 · 0 comments
Milestone

Comments

@bobmshannon
Copy link
Contributor

bobmshannon commented Nov 2, 2017

Bug report

When using the datadog output plugin, telegraf can log the datadog API key if the server is unreachable or in any scenario where debug information is logged that includes the HTTP query URI.

Relevant telegraf.conf:

Any configuration with the Datadog output plugin enabled.

System info:

Telegraf version 1.4.3

Expected behavior:

The API key should not be logged. In many cases, logs are aggregated in a central system viewable by multiple operators, and including sensitive information such as API keys is not ideal from a security standpoint.

Actual behavior:

The API key is logged:

Nov 02 07:13:03 x.x.x.x telegraf[722]: 2017-11-02T07:13:03Z W! Skipping a scheduled flush because there is already a flush ongoing.
Nov 02 07:14:03 x.x.x.x telegraf[722]: 2017-11-02T07:14:03Z W! Skipping a scheduled flush because there is already a flush ongoing.
Nov 02 07:28:03 x.x.x.x telegraf[722]: 2017-11-02T07:28:03Z W! Skipping a scheduled flush because there is already a flush ongoing.
Nov 02 07:29:33 x.x.x.x telegraf[722]: 2017-11-02T07:29:33Z W! Skipping a scheduled flush because there is already a flush ongoing.
Nov 02 07:35:33 x.x.x.x telegraf[722]: 2017-11-02T07:35:33Z W! Skipping a scheduled flush because there is already a flush ongoing.
Nov 02 07:35:33 x.x.x.x telegraf[722]: 2017-11-02T07:35:33Z E! Error writing to output [datadog]: error POSTing metrics, Post https://app.datadoghq.com/api/v1/series?api_key=<<SNIPPED>>
Nov 02 07:35:48 x.x.x.x telegraf[722]: 2017-11-02T07:35:48Z E! Error writing to output [datadog]: error POSTing metrics, Post https://app.datadoghq.com/api/v1/series?api_key=<<SNIPPED>>
Nov 02 07:36:03 x.x.x.x telegraf[722]: 2017-11-02T07:36:03Z W! Skipping a scheduled flush because there is already a flush ongoing.
Nov 02 07:36:05 x.x.x.x telegraf[722]: 2017-11-02T07:36:05Z E! Error writing to output [datadog]: error POSTing metrics, Post https://app.datadoghq.com/api/v1/series?api_key=<<SNIPPED>>
Nov 02 07:36:19 x.x.x.x telegraf[722]: 2017-11-02T07:36:19Z E! Error writing to output [datadog]: error POSTing metrics, Post https://app.datadoghq.com/api/v1/series?api_key=<<SNIPPED>>
@bobmshannon bobmshannon changed the title Datadog output plugin can log API key Datadog output plugin logs API key Nov 3, 2017
@danielnelson danielnelson added this to the 1.4.4 milestone Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants