Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant newlines from test cases that Go 1.18 treats as errors #10847

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

jawn-smith
Copy link
Contributor

resolves #10846

Removed redundant newlines to enable the test cases and usage statements to successfully build with Go 1.18.

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@jawn-smith
Copy link
Contributor Author

!signed-cla

@jawn-smith jawn-smith changed the title internal,plugins: remove redundant newlines from test cases that Go 1.18 treats as errors fix: remove redundant newlines from test cases that Go 1.18 treats as errors Mar 17, 2022
@jawn-smith
Copy link
Contributor Author

Sorry for all the force pushes, I was trying to make the semantic check happy.

@powersj
Copy link
Contributor

powersj commented Mar 18, 2022

Hey!

Thank you for the issue and PR! We are in a bit of a quiet period before our next release, but once out I will take a deeper look at this and expect to merge it.

Thanks again!

@powersj powersj merged commit 5992fc4 into influxdata:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some test cases and usage statement fail to build with Go 1.18
2 participants