Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser.xpath): Handle floating-point times correctly #11875

Merged
merged 2 commits into from Oct 3, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Sep 23, 2022

resolves #11864
lays foundation for resolving #11544

This PR fixes issues when providing the timestamp as floating-points in exponential notation. Furthermore, it revamps the internal ParseTimestamp() function to also return precise timestamps for unix_ms and unix_ns, handle above mentioned floating-point values and strings with thousand separators.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels Sep 23, 2022
@srebhan srebhan requested a review from reimda September 23, 2022 12:54
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome and I appreciate you going through it in pairs. It does set up changes for #11544 nicely.

athornton added a commit to lsst-sqre/telegraf that referenced this pull request Sep 29, 2022
…fka-regexp

Let Influx timestamp parsing from influxdata#11875 do the work for us
@athornton
Copy link
Contributor

This simplified my life in #11816 considerably. Two thumbs up.

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 30, 2022
@reimda reimda merged commit 758f2cb into influxdata:master Oct 3, 2022
popey pushed a commit that referenced this pull request Oct 3, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
@srebhan srebhan deleted the xpath_time_fix branch November 7, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp is in milliseconds with floating point representation
4 participants