Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional output plugin for writing to OpenTSDB using telnet mode #182

Closed
wants to merge 14 commits into from

Conversation

@rplessl
Copy link
Contributor

rplessl commented Sep 10, 2015

Hi,

This additonal output plugin enables to write from telegraf to OpenTSDB using the telnet mode.

My Unit Tests are not 100% code coverage, at the moment I will write a MOC for OpenTSDB emulation which will follows in a second pull request.

I have signed already the CLA

Thanks for pulling in advance!

"time"

"github.com/influxdb/influxdb/client"
"github.com/influxdb/telegraf/outputs"

This comment has been minimized.

Copy link
@sparrc

sparrc Sep 10, 2015

Contributor

please run go fmt on your code, it looks like you have some space-indented lines here

This comment has been minimized.

Copy link
@rplessl

rplessl Sep 10, 2015

Author Contributor

fixed thanks for the hint

rplessl added 2 commits Sep 10, 2015
@sparrc

This comment has been minimized.

Copy link
Contributor

sparrc commented Sep 10, 2015

This is great, thanks much @rplessl! I can tell that you read the contributing guidelines :-) 👍 👍

re: unit tests, I'm not sure how much work it's going to be to mock openTSDB, but have you considered trying out a docker image of openTSDB rather than mocking it? The kafka output sink utilizes that for unit testing and it simplified things enormously.

@rplessl

This comment has been minimized.

Copy link
Contributor Author

rplessl commented Sep 10, 2015

thanks for the hint for unit tests- I will also take a docker image

@sparrc

This comment has been minimized.

Copy link
Contributor

sparrc commented Sep 10, 2015

You can do one or the other....basically would require adding the docker image to the scipts/docker-compose.yml file, then using testutil to get the host that the docker openTSDB is at. That would also make it part of a "long" unit test suite

@rplessl

This comment has been minimized.

Copy link
Contributor Author

rplessl commented Sep 14, 2015

Hi @sparrc:
As discussed last week, I have added several unit tests using OpenTSDB a docker image.
Could you pull it?

@sparrc

This comment has been minimized.

Copy link
Contributor

sparrc commented Sep 14, 2015

thanks @rplessl, I'm going to try to merge this today 👍

@sparrc sparrc closed this in 9a0c088 Sep 15, 2015
@rplessl rplessl deleted the ninech:opentsdb_output_plugin_telnet branch Dec 2, 2015
whpearson pushed a commit to alphagov/telegraf that referenced this pull request Apr 9, 2018
* Added close callback

* Updated docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.