New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flume input plugin #3771

Open
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Icarus0xff
Copy link

Icarus0xff commented Feb 8, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.
@danielnelson

This comment has been minimized.

Copy link
Contributor

danielnelson commented Feb 9, 2018

Thanks for the pull request @hikkikuma1991, could you modify the HTTP client to use a non-default Transport and add SSL/TLS support? A good example of this is in the nginx plugin: https://github.com/influxdata/telegraf/blob/master/plugins/inputs/nginx/nginx.go#L63

Also, can you add some unit tests for the example JSON? Again you could base it on the nginx tests: https://github.com/influxdata/telegraf/blob/master/plugins/inputs/nginx/nginx_test.go

@AAbouZaid

This comment has been minimized.

Copy link

AAbouZaid commented Feb 25, 2018

Well, I create Flume plugin 2 weeks ago but didn't find time to push it 😂
But at least it's here now 🎉

I will make some PR to @hikkikuma1991 repo to add some useful parts like:

  • Multi urls/servers.
  • Filtering.
  • Numerical output (not string as they come from Flume metrics API).

@hikkikuma1991 I'd suggest default behavior to be collecting all metrics, and make option to filter them in case that needed, because in Flume the metrics could be extended with extra classes.

@AAbouZaid

This comment has been minimized.

Copy link

AAbouZaid commented Feb 25, 2018

@danielnelson I have a question.
I do see the HTTP client part again and again in many plugins, shouldn't this be a library or so to make it easier to use it?

@danielnelson

This comment has been minimized.

Copy link
Contributor

danielnelson commented Mar 6, 2018

I do see the HTTP client part again and again in many plugins, shouldn't this be a library or so to make it easier to use it?

Yes, likely. I'll try to work something out soon.

@russorat

This comment has been minimized.

Copy link
Contributor

russorat commented Mar 22, 2018

@hikkikuma1991 looks like according to the flume docs, monitoring is still a work in progress: https://flume.apache.org/FlumeUserGuide.html#monitoring

We'll probably hold off merging this until more people are using it or the flume monitoring stabilizes.

@russorat russorat removed the triage label Mar 22, 2018

Icarus0xff and others added some commits Apr 8, 2018

hikkikuma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment