facet specs (doesn't help #183, but does narrow it down) #187

Merged
merged 2 commits into from Oct 10, 2012

Projects

None yet

3 participants

@mrflip
Member
mrflip commented Oct 5, 2012

The instances do get overridden correctly in the dsl.

Found another problem, which is that repeated calls to Ironfan.cluster() should NOT replace the cluster definition.

Philip (flip... added some commits Oct 5, 2012
Philip (flip) Kromer Specs around facet (does not help #183)
dsl seems to handle override of facet instances just fine; error must lie elsewhere
370b9bc
Philip (flip) Kromer Ironfan.cluster() gives you back cluster if defined, does not overrid…
…e it

This makes its behavior consistent with gorillib collection behavior everywhere else.
e536bae
@nickmarden
Contributor

Ah yes, that is probably a better version of what I intended with these lines. My comments on L64-65 are probably misleading after this change, though.

Contributor

The commentary is by commit, so it looks fine.

@temujin9 temujin9 merged commit 1eef521 into master Oct 10, 2012
@temujin9
Contributor

This actually produces a lot of failing tests: are they documentary of underlying issues, or are the specs malformed? Reverted the merge until we can figure out the right solution; I'd like to think carefully before merging commits that result in broken specs, as that leads to the bad situation of "expecting the specs to fail".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment