Re-enables integration specs, explicitly excluding them from "rake spec" #198

Merged
merged 1 commit into from Oct 23, 2012

Conversation

Projects
None yet
2 participants
@nickmarden
Contributor

nickmarden commented Oct 23, 2012

No description provided.

@nickmarden

This comment has been minimized.

Show comment
Hide comment
@nickmarden

nickmarden Oct 23, 2012

Owner

Just for the record, it IS intentional that these two PEM files were included in the commit.

The idea is that ANY person running "rake integration" is welcome to use this (free) OpsCode testing account to do so. However, they will need to provide their own AWS credentials so that resource turn-up/turn-down can be accomplished. Those credentials go in the (missing) file named minimal-chef-repo/knife/credentials/knife-user-ironfantester.rb

Just for the record, it IS intentional that these two PEM files were included in the commit.

The idea is that ANY person running "rake integration" is welcome to use this (free) OpsCode testing account to do so. However, they will need to provide their own AWS credentials so that resource turn-up/turn-down can be accomplished. Those credentials go in the (missing) file named minimal-chef-repo/knife/credentials/knife-user-ironfantester.rb

@temujin9

This comment has been minimized.

Show comment
Hide comment
@temujin9

temujin9 Oct 23, 2012

Contributor

Problem with the missing-file issue is that gemspec complains when trying to cut a new gem. We need a different mechanism to reference the "might be missing" file.

Contributor

temujin9 commented Oct 23, 2012

Problem with the missing-file issue is that gemspec complains when trying to cut a new gem. We need a different mechanism to reference the "might be missing" file.

@nickmarden

This comment has been minimized.

Show comment
Hide comment
@nickmarden

nickmarden Oct 23, 2012

Contributor

I'm not sure what you mean. The missing file (knife-user-ironfantester.rb) isn't referenced as a "require" statement anywhere. Its existence is a bit of a state secret that gemspec couldn't possibly know about.

Can you tell me how to reproduce the issue you're seeing?

Contributor

nickmarden commented Oct 23, 2012

I'm not sure what you mean. The missing file (knife-user-ironfantester.rb) isn't referenced as a "require" statement anywhere. Its existence is a bit of a state secret that gemspec couldn't possibly know about.

Can you tell me how to reproduce the issue you're seeing?

@temujin9

This comment has been minimized.

Show comment
Hide comment
@temujin9

temujin9 Oct 23, 2012

Contributor

I think the .pem files were dangling symlinks the first time. They work fine now (from a gem-cutting perspective), but they are also full of actual credentials . . . are you sure you want to publish those?

Contributor

temujin9 commented Oct 23, 2012

I think the .pem files were dangling symlinks the first time. They work fine now (from a gem-cutting perspective), but they are also full of actual credentials . . . are you sure you want to publish those?

@temujin9

This comment has been minimized.

Show comment
Hide comment
@temujin9

temujin9 Oct 23, 2012

Contributor

(If they're the credentials you use for the VCR, and you turn them off on IAM on your end, it should be okay: I just want to be certain before I cut the gem.)

Contributor

temujin9 commented Oct 23, 2012

(If they're the credentials you use for the VCR, and you turn them off on IAM on your end, it should be okay: I just want to be certain before I cut the gem.)

@nickmarden

This comment has been minimized.

Show comment
Hide comment
@nickmarden

nickmarden Oct 23, 2012

Contributor

The pem files in question - ironfantest-validator.pem and ironfantester.pem - are credentials for a free OpsCode Hosted Chef account. They are intended to be shared between people who want to run the integration test.

What shouldn't be present in the commit is the file knife-user-ironfantester.rb. It contains the sensitive AWS credentials that could be abused if published on the Interwebs.

Contributor

nickmarden commented Oct 23, 2012

The pem files in question - ironfantest-validator.pem and ironfantester.pem - are credentials for a free OpsCode Hosted Chef account. They are intended to be shared between people who want to run the integration test.

What shouldn't be present in the commit is the file knife-user-ironfantester.rb. It contains the sensitive AWS credentials that could be abused if published on the Interwebs.

@temujin9

This comment has been minimized.

Show comment
Hide comment
@temujin9

temujin9 Oct 23, 2012

Contributor

Ah, yes, you're right: those are Opscode, not AWS. Cutting the gem now.

Contributor

temujin9 commented Oct 23, 2012

Ah, yes, you're right: those are Opscode, not AWS. Cutting the gem now.

@temujin9 temujin9 merged commit 15e2eb0 into infochimps-labs:master Oct 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment