Skip to content

196_elastic_ips #219

Merged
merged 20 commits into from Dec 10, 2012

2 participants

@schade
schade commented Dec 10, 2012

As requested at #196 (comment), Ironfan will now associate an Elastic IP given via the facet definition for acol-vpn in clusters/acol.rb currently found on the testmonkey repo (example here #219 (comment)).

Also, per the same request, knife cluster ssh <facet-name> will use the Elastic IP if it has been set on the machine.

NOTE:
Current to_display methods in Ironfan cause the Elastic IP to not always show properly in your CLI console if a public_ip_address was previously assigned to the instance, but only until the next sync run; that particular item is beyond the scope of the original request.

Jerry Jackson and others added some commits Nov 7, 2012
Jerry Jackson pushing minor changes from before start of feature code session e4c13fa
Jerry Jackson Adding code to activate Elastic IPs to lib/ironfan/dsl/ec2.rb 8255f6f
Jerry Jackson Merge branch 'master' of https://github.com/infochimps-labs/ironfan a15daae
Jerry Jackson Merge branch 'master' of https://github.com/infochimps-labs/ironfan 1710c8d
Jerry Jackson added some more bits to recognize elastic ips; Ironfan still ignoring…
… my pleas to asscoiate at this point in time.
414e149
Jerry Jackson pushed still non-working state to repo for coop testing 714f53c
Jerry Jackson recent changes added to the mix; todo: fix missing method 951b9dc
Jerry Jackson Elastic IP now attaches at launch time; still working on knife cluste…
…r ssh functionality.
e6418e6
@schade schade Merge pull request #1 from schade/feature/196_elastic_ips
Feature/196 elastic ips; non-final
bfe0b9f
Jerry Jackson added changes to various ec2 files for setting up basic elastic ip fu…
…nctionality
f4e8485
Jerry Jackson Merge branch 'master' of https://github.com/infochimps-labs/ironfan i…
…nto feature/196_elastic_ips
5f269ba
Jerry Jackson We fixed the rather odd, broken adaptee problem; now working on actua…
…lly associating addresses.
2f6c7c4
Jerry Jackson Merge branch 'master' of https://github.com/infochimps-labs/ironfan i…
…nto feature/196_elastic_ips
ce3dd0a
Jerry Jackson pushing changes that put us back in a state which completes the run w…
…ithout errors; still isn't attaching the elastic ip but is going through the motions.
76448df
Jerry Jackson push yesterday's changes to personal repo so that work can be done on…
… remaining issues.
8603763
Jerry Jackson Elastic IPs now properly attach at save/sync and are used when availa…
…ble by 'knife cluster ssh' as requested.
00aad33
Jerry Jackson Elastic IPs now properly attach at save/sync and are used when availa…
…ble by 'knife cluster ssh' as requested. Removed a last remaining 'raise hell' using during testing from machine.rb
94287ef
@schade schade Merge pull request #2 from schade/feature/196_elastic_ips
Feature/196 elastic ips
13e68a6
Jerry Jackson Continuing removal of miscellaneous bits used for testing during bug …
…wrangling sessions.
cefc539
Jerry Jackson Merge branch 'develop' of https://github.com/schade/ironfan into develop 468b81f
@temujin9

Looks good, though I see some minor tweaks. I'll make them, just pointing out for next time:

  • Don't duplicate information if it can be inferred (domain is equivalent vpc.nil? ? 'standard' : 'vpc')
  • Your FIXME shim on new is now unnecessary (underlying bug squashed during later dev?)
  • Cleaned up the legacy debugging code, to throw debugging statements in more general cases
@temujin9 temujin9 merged commit 21dd0d5 into infochimps-labs:master Dec 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.