Update ELB creation code to reflect new SSLNegotiationPolicyType behavio... #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rs
AWS recently changed the behavior of the SSLNegotiationPolicyType component of the createListener call, so that one can longer simply specify all of the ciphers that should be disallowed from the standard slate of available policies. Now one must specify which ciphers should be allowed as well. This was breaking automated ELB creation in ironfan, and this pull request fixes it by adding the
elastic_load_balancersetting calledallowed_ciphers, and by setting (new) reasonable defaults for bothallowed_ciphersanddisallowed_ciphers