Allow default cluster/facet roles to be overridden #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def initialize clname | ||
| super(clname) | ||
| @facets = {} | ||
| chef_attributes :cluster_name => clname | ||
| cluster_role clname |
There was a problem hiding this comment.
Looks good but can you make it so this assigns the role "#{clname}_cluster" (meaning the change is zero-impact) -- given that fix I'll merge
|
Whoops. Fixed. |
howech
added a commit
that referenced
this pull request
May 16, 2011
Allow default cluster/facet roles to be overridden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently each created node gets two default roles named "#{cluster_name}" and "#{cluster_name}_facet". This is a great convention but users should have the option to do something different.
This patch introduces the cluster_role and facet_role options to allow custom roles to be used or to disable the role addition by setting cluster/facet_role to false.