Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focusing with tab and then pressing enter stopped working #145

Closed
infokiller opened this issue Apr 10, 2020 · 8 comments
Closed

Focusing with tab and then pressing enter stopped working #145

infokiller opened this issue Apr 10, 2020 · 8 comments
Labels
bug fixed upstream The issue is fixed in the latest upstream code version, but not necessarily in all releases.

Comments

@infokiller
Copy link
Owner

This is a great extension, but not being able to get to these other links is the biggest problem for me.

I do not mind using TAB and SHIFT-TAB to navigate to these links, but when I press ENTER, what happens is that that link will be activated at the same time as the link that this extension is marking, which then opens.

Is there any way of deactivating the extension momentarily?

Originally posted by @eggbean in #97 (comment)

@infokiller infokiller added the bug label Apr 10, 2020
@infokiller infokiller changed the title Focusing with tab and then pressing enter stopped working working Focusing with tab and then pressing enter stopped working Jun 2, 2020
@infokiller infokiller reopened this Jun 5, 2020
@infokiller
Copy link
Owner Author

I think this is now fixed in the latest master branch.
Just so that I can verify, do you have an example search query I can test?
Screenshots will also be useful to verify I'm looking at the same results.

@eggbean
Copy link

eggbean commented Jun 20, 2020

image

  • I used the up/down arrow keys and have marked link 1

  • Then I used SHIFT+TAB until link 2 is marked and press ENTER but link 1 opens instead.

@infokiller
Copy link
Owner Author

This works for me. Can you try the latest master branch to see if it's fixed for you?

Run this in a shell:

git clone https://github.com/infokiller/web-search-navigator
cd web-search-navigator
yarn install && yarn build

Then load the unpacked extension from the src folder.
If you don't want to install/run git/yarn, let me know and I can also send a zip file of the build.
Also let me know if you need help on loading an unpacked chrome extension.

@eggbean
Copy link

eggbean commented Jun 21, 2020

Then load the unpacked extension from the src folder.

I have built it using yarn, but I am not sure what I am supposed to do afterwards.
After building the only difference seems to be the contents of node_modules. Is that right?

@infokiller
Copy link
Owner Author

The contents of node_modules change when you run yarn install, but after you run yarn build it should also add a few more files to the src directory.

Anyway, I actually discovered a method that is easier and safer from mistakes. First cd to the project directory and then:

# Update the project to latest version
git pull
# Install dependencies and build the extension
yarn install && yarn build
# Run a browser with the extension. Replace '--target chromium' with "--target firefox-desktop" for Firefox.
yarn run web-ext run --source-dir src --start-url 'https://www.google.com/search?q=hare+vs+rabbit' --target chromium

This will open a new browser profile with only the extension already loaded.

@eggbean
Copy link

eggbean commented Jun 21, 2020

Could you package this so that I can try it? Thanks.

@infokiller
Copy link
Owner Author

wsn.zip

@eggbean
Copy link

eggbean commented Jun 22, 2020

Excellent. Thanks, it's working fine now 😃

@infokiller infokiller added fixed upstream The issue is fixed in the latest upstream code version, but not necessarily in all releases. and removed fixed on master labels Jun 22, 2020
@infokiller infokiller removed the waiting label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed upstream The issue is fixed in the latest upstream code version, but not necessarily in all releases.
Projects
None yet
Development

No branches or pull requests

2 participants