Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time filter calendar control enhacements #534

Open
3 of 6 tasks
ameliebernier opened this issue Dec 17, 2019 · 2 comments · Fixed by #621
Open
3 of 6 tasks

Time filter calendar control enhacements #534

ameliebernier opened this issue Dec 17, 2019 · 2 comments · Fixed by #621
Labels
enhancement
Milestone

Comments

@ameliebernier
Copy link
Contributor

ameliebernier commented Dec 17, 2019

  • Igo Version: 1.1

Three proposed enhacement for the calendar control in time filter tool :

  • We should be able to set the date manually (at the moment we can only use the calendar)

  • Calendar should show the currently selected date

  • The date should be in correct format according to locale (actually displays as MM/DD/YYYY in french-ca locale, should be YYYY-MM-DD)

  • Possibility to remove date (for example, end date of filter is undefined, so every features after start date are displayed)

  • Calendar icon should align correctly above the input line

image

  • When defining a min date for timeFilter param in context, the day before is available in the calendar, However if this date is chosen the control remains invalid. Exemple with min date of time filter = 1990-01-01 : 1989-12-31 is available in calendar, but control is invalid if selected

image

@ameliebernier ameliebernier added the enhancement label Dec 17, 2019
@ameliebernier ameliebernier changed the title Can't enter date manually in time filter calendar control Time filter calendar control enhacements Dec 17, 2019
@mbarbeau mbarbeau added this to To do in IGO2 - Roadmap V1.4 via automation Jan 24, 2020
@PhilippeLafreniere18 PhilippeLafreniere18 added this to the es123 milestone Apr 28, 2020
@PhilippeLafreniere18
Copy link
Collaborator

PhilippeLafreniere18 commented Apr 29, 2020

Point 2, 5 et 6 réglé avec pull request #621.

@mbarbeau
Copy link
Member

mbarbeau commented Apr 30, 2020

in my opinion the format "DD/MM /YYYY" is correct

@mbarbeau mbarbeau removed this from To do in IGO2 - Roadmap V1.4 May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants