feat(edition): allow send config option / url call for dom / add, modify, delete disabled button config#1048
Merged
Merged
Conversation
PhilippeLafreniere18
changed the title
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
…ify, delete disabled button config (#1048) * feat(edition): allow send config option and url call for dom * feat(edition): add button disabled config * refactor(edition): Edit mode only with state view * feat(edition): force column value * fix(edition): fix edition mode dom value set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Nothing discriminate which source field you really want to send on add/modify action
Predefined url are not considered for relation http call
add, remove and modify buttons are always available
Edit mode shows all other features (in edit mode or not) and causes some problems with multiple domain value
What is the new behavior?
"send" config allow to send or not send sourceFields on add/modify action
"url" can now be part of relation options config
add, remove and modify buttons can now be set to disabled directly by layer edition options
Edit mode only shows the feature in edit mode
Does this PR introduce a breaking change? (check one with "x")