Skip to content

feat(draw): Management of the editing of the labels#1059

Merged
pelord merged 7 commits into
nextfrom
DessinGestionDesEtiquettes
Jun 10, 2022
Merged

feat(draw): Management of the editing of the labels#1059
pelord merged 7 commits into
nextfrom
DessinGestionDesEtiquettes

Conversation

@kalvinkhuu

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

Link to the issue

What is the new behavior?

  1. Added a cancel button with its respective logic
  2. Allowing the user to double click the selected drawing to edit its label
  3. User can now edit the font size and style of the labels of their drawings

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@PhilippeLafreniere18 PhilippeLafreniere18 marked this pull request as draft May 20, 2022 19:12

@PhilippeLafreniere18 PhilippeLafreniere18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the form-field for font type and size is a little bit big in the igo2 display. Maybe minimize it a bit and place them side by side ?

Comment thread packages/geo/src/lib/draw/draw/draw-popup.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.ts Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.ts Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.ts Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.ts Outdated
Comment thread packages/geo/src/lib/draw/shared/draw-style.service.ts Outdated
@PhilippeLafreniere18 PhilippeLafreniere18 marked this pull request as ready for review June 2, 2022 20:31
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
Comment thread packages/geo/src/lib/draw/draw/draw.component.html Outdated
@pelord

pelord commented Jun 10, 2022

Copy link
Copy Markdown
Member

@PhilippeLafreniere18 1.12 is the target?

@pelord pelord merged commit 2c039e2 into next Jun 10, 2022
@pelord pelord deleted the DessinGestionDesEtiquettes branch June 10, 2022 13:18
cbourget pushed a commit that referenced this pull request Mar 21, 2023
* Merge branch 'DrawingGestionOnLabels' into DessinGestionDesEtiquettes

* formatted the html

* format ts file

* Fixed some formatting issues

* Redid design of the inputs box

* Reformatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants