feat(draw): Management of the editing of individual element #1065
Merged
Conversation
* In the store, each entities have their own style, but when applying the style, * the setStyle function does not recognize each entities * * TODO: * Either redo the setStyle function to take in entities or find a * way to change the features inside the store * * When changing the label, set the style to the original style * * Repeat this for all colors * * Remove any useless things and add comments
Need to do onColorChange
draw.interface.ts: Add attributes for color stroke and color fill draw.component.ts: Change the global variables of fillForm and strokeForm Create functions to return their color stroke and fill Do a similar thing as onFontChange draw-style.service.ts (Housecleaning: Change the variable for the properties of each features)
Bugs: - When moving the drawing, it resets the color and the font - When the user edits the label, it bugs the whole website
Might change the design of the page
Started playing with the design of the page
Need to clean the code and work on if it is an icon
Uses the length of the store ()
PhilippeLafreniere18
requested changes
Jul 6, 2022
PhilippeLafreniere18
approved these changes
Jul 7, 2022
…/infra-geo-ouverte/igo2-lib into DessinApplicationStyleParElement
pelord
requested changes
Oct 27, 2022
Member
pelord
left a comment
pelord
left a comment
There was a problem hiding this comment.
bundle the feature style changer into a standalone component
PhilippeLafreniere18
added
ready to merge
and removed
in progress
pelord
approved these changes
Nov 2, 2022
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Merge branch 'DrawingGestionOnLabels' into DessinGestionDesEtiquettes * Progress in the selection of the element * In the store, each entities have their own style, but when applying the style, * the setStyle function does not recognize each entities * * TODO: * Either redo the setStyle function to take in entities or find a * way to change the features inside the store * * When changing the label, set the style to the original style * * Repeat this for all colors * * Remove any useless things and add comments * Working selection of an element for font size and font style Need to do onColorChange * TODO next week draw.interface.ts: Add attributes for color stroke and color fill draw.component.ts: Change the global variables of fillForm and strokeForm Create functions to return their color stroke and fill Do a similar thing as onFontChange draw-style.service.ts (Housecleaning: Change the variable for the properties of each features) * Selection per element for the color works Bugs: - When moving the drawing, it resets the color and the font - When the user edits the label, it bugs the whole website * Working features Might change the design of the page * Partially clean it up Started playing with the design of the page * Implemented edition of the position of label Need to clean the code and work on if it is an icon * Cleaned up the code * Added a CSS style for the edition of the draw * removed unused code * Initial scrollbar for the table * Progress in table * Update entity-table.component.html * formatted the html * format ts file * Fixed some formatting issues * Redid design of the inputs box * updated format * edit the formatting * Update package-lock.json * Implemented a possible solution * Dynamic table height Uses the length of the store () * Update to fit 6 elements of the table * Cleaned up the code * Reformatting * reformating * reformatting * Requested changes * updateFrontend to getFeature * fix ol geometry type * remove flashing from layer refresh * fix(draw): fix font and offset flashing geom change * feat(draw): only display border color with linestring * feat(layer): add reusable style modal component * fix/feat(draw): upgrade to color-picker 13 + icon and modal fix * i18n(draw): traduction change * fix/feat(draw): deselect on init / css minor fix / add tooltip Co-authored-by: Philippe Lafreniere <philippe.lafreniere@msp.gouv.qc.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Link to the issue
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: