feat(draw): Drawing coordinate label#1092
Merged
Merged
Conversation
* In the store, each entities have their own style, but when applying the style, * the setStyle function does not recognize each entities * * TODO: * Either redo the setStyle function to take in entities or find a * way to change the features inside the store * * When changing the label, set the style to the original style * * Repeat this for all colors * * Remove any useless things and add comments
Need to do onColorChange
draw.interface.ts: Add attributes for color stroke and color fill draw.component.ts: Change the global variables of fillForm and strokeForm Create functions to return their color stroke and fill Do a similar thing as onFontChange draw-style.service.ts (Housecleaning: Change the variable for the properties of each features)
Bugs: - When moving the drawing, it resets the color and the font - When the user edits the label, it bugs the whole website
Might change the design of the page
Started playing with the design of the page
Need to clean the code and work on if it is an icon
Uses the length of the store ()
PhilippeLafreniere18
changed the title
pelord
requested changes
Nov 21, 2022
pelord
left a comment
pelord
left a comment
Member
There was a problem hiding this comment.
allow area and perimeters for polygon? (check box?)
when you edit a polygon with label.. his current label type is not checked.
Contributor
Fix |
pelord
requested changes
Nov 28, 2022
pelord
left a comment
pelord
left a comment
Member
There was a problem hiding this comment.
1-more digits on coordinates
2- translate A: for polygon area,
pelord
approved these changes
Nov 30, 2022
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
…th,perimeter)(#1092) * Merge branch 'DrawingGestionOnLabels' into DessinGestionDesEtiquettes * Progress in the selection of the element * In the store, each entities have their own style, but when applying the style, * the setStyle function does not recognize each entities * * TODO: * Either redo the setStyle function to take in entities or find a * way to change the features inside the store * * When changing the label, set the style to the original style * * Repeat this for all colors * * Remove any useless things and add comments * Working selection of an element for font size and font style Need to do onColorChange * TODO next week draw.interface.ts: Add attributes for color stroke and color fill draw.component.ts: Change the global variables of fillForm and strokeForm Create functions to return their color stroke and fill Do a similar thing as onFontChange draw-style.service.ts (Housecleaning: Change the variable for the properties of each features) * Selection per element for the color works Bugs: - When moving the drawing, it resets the color and the font - When the user edits the label, it bugs the whole website * Working features Might change the design of the page * Partially clean it up Started playing with the design of the page * Implemented edition of the position of label Need to clean the code and work on if it is an icon * Cleaned up the code * Added a CSS style for the edition of the draw * removed unused code * Initial scrollbar for the table * Progress in table * Update entity-table.component.html * formatted the html * format ts file * Fixed some formatting issues * Redid design of the inputs box * updated format * edit the formatting * Update package-lock.json * Implemented a possible solution * Dynamic table height Uses the length of the store () * Update to fit 6 elements of the table * Cleaned up the code * Reformatting * reformating * reformatting * Redid the files since next * UI modifications * UI and logic changes * 1.12.0 * Added a popup dialog * Added the json lines for the layer * Update draw.component.ts * Changed the logic * Still does not retain the info * working logic with few bugs * Made an Output and input for DC * Working prototype * Cleaning the code * Update draw.component.ts * Requested changes * updateFrontend to getFeature * Update draw.component.ts * Fix bugs * Update draw.component.ts * formatting * Added logic to the toggles * small changes * initial changes * Logic working with few bugs * Working logic * removed console * Missing CSS edits * Working logic with editLabel * Added vocab and modified UI * lint.fix * Changed logic and design * Updated the logic * Small design and logic changes TODO: Implement the measuring logic: measureOlGeometry Attach it to the Frontend Create logic for dynamic changes on onModify * Popup measuring logic done * UI changes * measuring logic working * lint fix * started the Circle logic * Working logic for the circle length and area * Circle logic works * working logic for coordinates and nicer UI * small changes * lint.fix * UI changes * final revisions hopefully * Added small changes * tests with the buffer * removed the spacial * some changes with the UI * UI changes and final version * lint * fix(draw): css minor fix * feat(draw): Allow area and length label por polygon, get draw label on edit * fix(draw): keep 5 digits on coord/fix manage checkbox and area translate * feat(map.utils): add method to round coord and then convert to strinn array * refactor(draw): use existing method to round coordinates Co-authored-by: Philippe Lafreniere <philippe.lafreniere@msp.gouv.qc.ca> Co-authored-by: Pierre-Étienne Lord <pe_lord@yahoo.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Link to the issue
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information:
This branch is based off the branch DessinPlusieursCouches2.0. After the PR of that branch is pushed through, the changes should not be as big as it is initially.