refactor(layerSync): init layer sync + ogcFilters$ remove#1107
Merged
Conversation
… layers links are now bidirectionnal.
PhilippeLafreniere18
marked this pull request as ready for review
October 13, 2022 12:11
3 tasks
PhilippeLafreniere18
approved these changes
Oct 13, 2022
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* try * lint * synchronize the common properties * lint * common property sync properly * wip * wip * wip * delete layersync watcher * pull #1089 * wip * Commentaires pour phil * refactor(layerSync): init layer sync + ogcFilters$ remove * lint * refactor(linkedLayer): layer displacement within layer list * refactor(layerSync): handle layer deletion * lint * BREAKING CHANGE(layer sync): Deletion of bidirectionnal property, all layers links are now bidirectionnal. * minor fix Co-authored-by: Pierre-Étienne Lord <pe_lord@yahoo.ca> Co-authored-by: Philippe Lafreniere <philippe.lafreniere@msp.gouv.qc.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
In the nextg branch (1.13.0 rc), the layer sync do not work at all.
A refactor was required.
What is the new behavior?
Layer sync was refactored and the layer synchronization was delegated to the map instead of each layers.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
[BREAKING CHANGE(layer sync): Deletion of bidirectionnal property, all layers links are now bidirectionnal.
NO action required
Other information: