perf(geo): changer l'affichage de Query du liste collapse ver afficha…#1156
Merged
perf(geo): changer l'affichage de Query du liste collapse ver afficha…#1156
Conversation
Contributor
PhilippeLafreniere18
left a comment
PhilippeLafreniere18
left a comment
There was a problem hiding this comment.
I think it would be great if the toast-panel height doesn't change with each layer. Currently, if I have a lot of features of one layer and only a few from another, the panel will resize from big to small abruptly. Maybe another way would be to add an animation that can soften the resize.
Contributor
|
Event with the animation, the resize can be a bit abrupt especially when you pass from one layer that has many query features from one that has few... I really think the best here would be to fix the height of the panel according to the fullExtent attribute and the layer that has the highest number of query features. |
PhilippeLafreniere18
added
ready to merge
1.14.2
and removed
in progress
PhilippeLafreniere18
approved these changes
Mar 10, 2023
pelord
approved these changes
Mar 15, 2023
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
…st (#1156) * perf(geo): changer l'affichage de Query du liste collapse ver affichage par onglet * verify the result for toast-panel or search-result-tools * rename variable * add animation to resize tabs content --------- Co-authored-by: Pierre-Étienne Lord <pierre-etienne.lord@transports.gouv.qc.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
This update relate to the issue #862 on igo2
What is the new behavior?
Change Query display in "toast-panel" from list collapse to tab display