feat(geo): add new option to reverse coord format#1159
Merged
Conversation
aziz-access
added
enhancement
aziz-access
changed the title
aziz-access
added
to test
PhilippeLafreniere18
requested changes
Feb 3, 2023
PhilippeLafreniere18
left a comment
PhilippeLafreniere18
left a comment
Contributor
There was a problem hiding this comment.
All good for me!
For spelling, please change all the "reverce" for "reverse"
The only thing is that when you click the reverse settings, i think it would be great if the active search is reloaded ? The user could therefore see in live action what the functionality does.
PhilippeLafreniere18
requested changes
Feb 16, 2023
PhilippeLafreniere18
left a comment
PhilippeLafreniere18
left a comment
Contributor
There was a problem hiding this comment.
There's still a problem with the feature details refresh when search is reloaded after the reverse settings is toggle.
aziz-access
added
in progress
aziz-access
added
to test
PhilippeLafreniere18
approved these changes
Feb 23, 2023
PhilippeLafreniere18
added
ready to merge
and removed
to test
pelord
requested changes
Mar 3, 2023
| (click)="$event.stopPropagation()" [checked]="searchResultsGeometryEnabled" [labelPosition]="'after'"> | ||
| {{'igo.geo.search.searchResultsGeometry.title' | translate}} | ||
| </mat-slide-toggle> | ||
| <mat-slide-toggle class="pointer-summary-option" (change)="reverseSearchCoordsFormat($event)" tooltip-position="below" |
| "tooltip": "Afficher/cacher la géométrie des résultats" | ||
| }, | ||
| "reverseCoordFormat": { | ||
| "title": "Inverser les coordonnées", |
Member
There was a problem hiding this comment.
Je changerais ce terme...
Afficher les données en latitude/longitude
Adapter la logique pour les tooltips!
| "tooltip": "Hide/ show the results geometries " | ||
| }, | ||
| "reverseCoordFormat": { | ||
| "title": "Reverse Coordinates", |
Member
There was a problem hiding this comment.
I would change that term...
Display data in latitude/longitude
Adapt logic for tooltips!
| @@ -488,11 +488,13 @@ export function roundCoordToString(coord: [number, number], decimal: number = 3) | |||
| * and for the current UTM zone and MTM zone. | |||
Member
There was a problem hiding this comment.
Add this new feature to the lib demo.
pelord
approved these changes
Mar 15, 2023
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* feat(geo): add new option ti change coord format * solve lint error * delete comments and add local text fr,en for the new search option * rename variable name and add translate to menu option * improve the code and reverce latlong from coordinates file * reverse UTM MTM data * solve lint error * change spelling reverce for reverse * reverse coord format lonlat latlon * feat(search-bar): adjust reverse coord status change * solve typo and class name * add reverse coord feature to the lib * sove lint * remove reverse coord for projection coordinates --------- Co-authored-by: Philippe Lafreniere <philippe.lafreniere@msp.gouv.qc.ca> Co-authored-by: Pierre-Étienne Lord <pierre-etienne.lord@transports.gouv.qc.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this update relate to the issue 782 on igo2
linked with infra-geo-ouverte/igo2#890
What is the new behavior?
Add new option in search settings to Reverse coords format from 'lonlat' to 'latLon'