feat(geo): save search results in layer - #1179
Merged
Merged
Conversation
aziz-access
added
enhancement
PhilippeLafreniere18
requested changes
Feb 14, 2023
PhilippeLafreniere18
left a comment
PhilippeLafreniere18
left a comment
Contributor
There was a problem hiding this comment.
Without testing, just a few minor comments
PhilippeLafreniere18
approved these changes
Feb 23, 2023
PhilippeLafreniere18
requested changes
Feb 23, 2023
PhilippeLafreniere18
left a comment
PhilippeLafreniere18
left a comment
Contributor
There was a problem hiding this comment.
Two problems here :
- I hit the following error when adding a new search feature to an existing search layer
- It seems to have a problem with z index criteria. Layer list should be sorted by z index, but when adding search layer, weird behavior is happening
…rty from drowinglayer to solve zindex issue
aziz-access
added
to test
PhilippeLafreniere18
added
ready to merge
and removed
to test
PhilippeLafreniere18
approved these changes
Mar 9, 2023
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* feat(geo): save search results in layer * create layer dialog * clean code * code cleaning back with collapsible component with first state * add feature ti layer btn and dialog * start create layer and add feature * edit layer * create layer and add new feature * save feature in layer * add translation and solve lint * solve lintt * solve comments * correct igo-search-layer * solve typo * add searchLayerStores to save new the storest and delete zIndex property from drowinglayer to solve zindex issue * solve lint error * typo * refactor(search-bar): allow queryable / switch to Feature * refactor(search-results-add-button): renamed const * fix/feat(search-results): fix translation/add feature properties --------- Co-authored-by: Philippe Lafreniere <philippe.lafreniere@msp.gouv.qc.ca> Co-authored-by: Pierre-Étienne Lord <pierre-etienne.lord@transports.gouv.qc.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
This update relate to the issue 896 in igo2.
What is the new behavior?
Save search results to an existing or a new layer.