Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export by url #661

merged 15 commits into from Jun 9, 2020

Export by url #661

merged 15 commits into from Jun 9, 2020


Copy link

@pelord pelord commented Jun 5, 2020

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
1- Non vector layers with download (url) property contained in sourceOptions are not exportable by the import/Export tool.
2- Vector layer that were not initialized (visibility set to false in config) were not exportable. This cause an error :

What is the new behavior?
1- These layers are now listed exportable. The associated export format is an URL and the form submit open the link.
2- On layer selection, if the vector contain no feature, the layer visibility is set to true, the opacity = 0 and queryable = false. Then OpenLayers download the features. On the next layer selection (or on tool leave) the previous layer original visibility, opacity and queryable status are "roolbacked".

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@pelord pelord requested a review from mbarbeau Jun 5, 2020
Copy link
Member Author

pelord commented Jun 5, 2020

@pelord pelord marked this pull request as ready for review Jun 8, 2020
@mbarbeau mbarbeau merged commit f1af5ed into next Jun 9, 2020
2 checks passed
@mbarbeau mbarbeau deleted the exportByUrl branch Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants