Export by url#661
Merged
Merged
Conversation
… in the format list
Member
Author
mbarbeau
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
1- Non vector layers with download (url) property contained in sourceOptions are not exportable by the import/Export tool.
2- Vector layer that were not initialized (visibility set to false in config) were not exportable. This cause an error :
What is the new behavior?
1- These layers are now listed exportable. The associated export format is an URL and the form submit open the link.
2- On layer selection, if the vector contain no feature, the layer visibility is set to true, the opacity = 0 and queryable = false. Then OpenLayers download the features. On the next layer selection (or on tool leave) the previous layer original visibility, opacity and queryable status are "roolbacked".
Does this PR introduce a breaking change? (check one with "x")