Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ogc during next #705

Merged
merged 27 commits into from
Sep 16, 2020
Merged

Ogc during next #705

merged 27 commits into from
Sep 16, 2020

Conversation

matrottier
Copy link
Contributor

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
ogc filter "During" use "string" as input

What is the new behavior?
ogc filter "During" use calendar as input

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@matrottier matrottier mentioned this pull request Aug 14, 2020
5 tasks
@pelord
Copy link
Member

pelord commented Aug 21, 2020

  1. Review the placement of during operator into the sidenav panel
    image

@pelord
Copy link
Member

pelord commented Aug 21, 2020

  1. Develop a method for same single date. Where the begin/end are the same.

@pelord
Copy link
Member

pelord commented Aug 21, 2020

  1. Does the time stepDate (P2D, PT4H, P1M...) should be proposed as a option to the user? i.e. a select?

@pelord
Copy link
Member

pelord commented Aug 21, 2020

  1. Why these properties are at the datasource level?

    minDate: '2016-01-01T00:00:00-05:00',
    maxDate: '2018-12-31T00:00:00-05:00',
    stepDate: 'P1M'

@pelord
Copy link
Member

pelord commented Aug 21, 2020

  1. Add an example into the igo2 demo.

@pelord pelord mentioned this pull request Sep 2, 2020
@matrottier
Copy link
Contributor Author

1- working on this
2- we must add a option, idea for the name ? in this case, we do not display the End Time because it will be start time + step.
3- maybe in advance mode. You must calculate all the possiblity of the WMS with the step. more complicate.
4- i saw it like the zoom option. it's the max/min of the datasource.
5- there is 6 examples:
Inondation (During, optionsFromCapabilities)
Embâcle (During, Interval from Now, Step: P1D)
Embâcle (During, Step: P1Y)
Embâcle (During, Step: P1M)
Embâcle (During, Step: PT4H)
Embâcle (During, Step: P2D)

@matrottier
Copy link
Contributor Author

OgcFilterDuringOptions : restrictToStep ?: boolean;
if true, only one date can be selected and the period is: selected date + 1x step.

@pelord
Copy link
Member

pelord commented Sep 8, 2020

OgcFilterDuringOptions : restrictToStep ?: boolean;
if true, only one date can be selected and the period is: selected date + 1x step.

And why + 1x step?

@matrottier
Copy link
Contributor Author

OgcFilterDuringOptions : restrictToStep ?: boolean;
if true, only one date can be selected and the period is: selected date + 1x step.

And why + 1x step?

to automatically calculate the end time.
did you want to send only one date ? ex: '2020-08-08 00:00:00'

@mbarbeau mbarbeau merged commit 496e9bb into next Sep 16, 2020
@mbarbeau mbarbeau deleted the ogcDuring_next branch September 16, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants