Conversation
implementation of the option to have a scaleBar to replace the scaleLine
adding controls for Contextmap
fix of a potential bug
scalebar is now centered
Mobile support for the scaleBar
fix of a breaking bug
fix style
mbarbeau
reviewed
May 17, 2021
| import { Injectable } from '@angular/core'; | ||
|
|
||
| import { IgoMap, MapService, ProjectionService } from '@igo2/geo'; | ||
| import { ContextState } from '../context'; |
Collaborator
Author
There was a problem hiding this comment.
nope I removed it!
mbarbeau
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
The current behavior is a normal scaleLine displayed in the map with no modifications possible.
What is the new behavior?
The new behavior gives the user the possibility to custom the scaleLine style and the possibility to hide or not the attributions displayed in the map.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: