Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale bar #859

Merged
merged 11 commits into from
May 26, 2021
Merged

Scale bar #859

merged 11 commits into from
May 26, 2021

Conversation

olivierSaintCyr
Copy link
Collaborator

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
The current behavior is a normal scaleLine displayed in the map with no modifications possible.

What is the new behavior?
The new behavior gives the user the possibility to custom the scaleLine style and the possibility to hide or not the attributions displayed in the map.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

implementation of the option to have a scaleBar to replace the scaleLine
adding controls for Contextmap
fix of a potential bug
scalebar is now centered
Mobile support for the scaleBar
fix of a breaking bug
@@ -1,6 +1,7 @@
import { Injectable } from '@angular/core';

import { IgoMap, MapService, ProjectionService } from '@igo2/geo';
import { ContextState } from '../context';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope I removed it!

@mbarbeau mbarbeau merged commit 4156461 into next May 26, 2021
@mbarbeau mbarbeau deleted the scaleBar branch May 26, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants