Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map): Advanced map tool #900

Merged
merged 46 commits into from
Aug 30, 2021
Merged

feat(map): Advanced map tool #900

merged 46 commits into from
Aug 30, 2021

Conversation

almat65
Copy link
Contributor

@almat65 almat65 commented Aug 17, 2021

Please check if the PR fulfills these requirements

What is the current behavior?
No advenced tools

What is the new behavior?
2 tools available. "Swipe" for compare the layers.
"Coordinates" for use the coordinates of the center of the map in differents projections. Display a cuttent zoom-level

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:
image

@pelord pelord changed the base branch from master to next August 17, 2021 18:47
@pelord pelord marked this pull request as draft August 17, 2021 18:51
@almat65 almat65 changed the title Advanced map tool feat(map): Advanced map tool Aug 17, 2021
this.currentCenterDefaultProj = this.map.viewController.getCenter(this.defaultProj.code);
const currentMtmZone = zoneMtm(this.currentCenterDefaultProj[0]);
const currentUtmZone = zoneUtm(this.currentCenterDefaultProj[0]);
if (!this.inQuebec && currentMtmZone !== this.currentZones.mtm) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename inquebec by inMtmZone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pelord pelord marked this pull request as ready for review August 20, 2021 13:02
@pelord
Copy link
Member

pelord commented Aug 20, 2021

},
"advanced-map-tool": {
"advanced-swipe":{
"swipe-select": "Choisir les couches à swiper",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "swiper" by "comparer"

@PhilippeLafreniere18 PhilippeLafreniere18 merged commit a0c7785 into next Aug 30, 2021
@PhilippeLafreniere18 PhilippeLafreniere18 deleted the coordinatesPEL branch August 30, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants