Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ogc-filter-time)- add calendar yearMode #907

Merged
merged 10 commits into from Sep 29, 2021
Merged

Conversation

josee666
Copy link

issues 624 [https://github.com/infra-geo-ouverte/igo2/issues/624]

What is the current behavior? (You can also link to an open issue here)
problem with date in year mode

What is the new behavior?

  • new param for ogcFilter during -> "calendarModeYear": true
    Exemple :
    "filters":
    {
    "operator": "During",
    "propertyName": "annee_date",
    "begin": "1890-01-01T00:00:00-05:00",
    "end": "2021-12-31T00:00:00-05:00",
    "restrictedToStep": false,
    "displayFormat": "YYYY",
    "calendarModeYear": true
    }
    },
    "stepDate": "P1Y"YearMode param add

  • new gui for "calendarModeYear": true -> show only year to user instead of year-month-day

  • in "calendarModeYear" fix the call to include the start and end year. (start:2020, end:2021 -> will show all 2020 and 2021 features)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [x ] No

@PhilippeLafreniere18
Copy link
Contributor

Everything works fine for me. Except, there seems to be a little delay when a year is selected (we see the month date picker for like half a seconds before it disappeared). Maybe set the month/day date before the selected year and not use the css display none to hide it ? I found an example that i think will suit our needs ( https://stackblitz.com/edit/angular-mulitdate-picker-demo?file=app%2Fmultidatepicker%2Fyear-picker-component%2Fyear-picker.component.ts )

@josee666
Copy link
Author

Some change have been made and it's ok now. @PhilippeLafreniere18 ready to merge in next
NzMZz8h8sU
w

@PhilippeLafreniere18 PhilippeLafreniere18 merged commit a57a000 into next Sep 29, 2021
@PhilippeLafreniere18 PhilippeLafreniere18 deleted the ogcTimeFilter branch February 23, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants