feat(ogc-filter-time)- add calendar yearMode - #907
Merged
Merged
Conversation
added 4 commits
August 31, 2021 10:45
Contributor
|
Everything works fine for me. Except, there seems to be a little delay when a year is selected (we see the month date picker for like half a seconds before it disappeared). Maybe set the month/day date before the selected year and not use the css display none to hide it ? I found an example that i think will suit our needs ( https://stackblitz.com/edit/angular-mulitdate-picker-demo?file=app%2Fmultidatepicker%2Fyear-picker-component%2Fyear-picker.component.ts ) |
Author
|
Some change have been made and it's ok now. @PhilippeLafreniere18 ready to merge in next |
PhilippeLafreniere18
approved these changes
Sep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

issues 624 [https://github.com/infra-geo-ouverte/igo2/issues/624]
What is the current behavior? (You can also link to an open issue here)
problem with date in year mode
What is the new behavior?
new param for ogcFilter during -> "calendarModeYear": true
Exemple :
"filters":
{
"operator": "During",
"propertyName": "annee_date",
"begin": "1890-01-01T00:00:00-05:00",
"end": "2021-12-31T00:00:00-05:00",
"restrictedToStep": false,
"displayFormat": "YYYY",
"calendarModeYear": true
}
},
"stepDate": "P1Y"YearMode param add
new gui for "calendarModeYear": true -> show only year to user instead of year-month-day
in "calendarModeYear" fix the call to include the start and end year. (start:2020, end:2021 -> will show all 2020 and 2021 features)
Does this PR introduce a breaking change? (check one with "x")