Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification: Deps change from angular2-notification to ngx-toastr #928

Merged
merged 13 commits into from
Dec 8, 2021

Conversation

pelord
Copy link
Member

@pelord pelord commented Oct 21, 2021

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

For the message options, refer to IndividualConfig interface from ngx-toastr
https://github.com/scttcper/ngx-toastr/blob/97e13cc86277e35bb72d7b50c26fef79237e546c/src/lib/toastr/toastr-config.ts#L13

Other information:

@pelord
Copy link
Member Author

pelord commented Oct 21, 2021

@sMoKeSz Related to flauc/angular2-notifications#382, I finally moved to ngx-toastr, quite easy.

@sMoKeSz
Copy link

sMoKeSz commented Oct 21, 2021

@sMoKeSz Related to flauc/angular2-notifications#382, I finally moved to ngx-toastr, quite easy.

I did it also after I wrote the comment :)

@pelord pelord marked this pull request as ready for review October 22, 2021 18:05
@pelord pelord marked this pull request as draft November 9, 2021 19:42
@pelord pelord marked this pull request as ready for review November 30, 2021 18:50
@pelord pelord merged commit 82544c0 into next Dec 8, 2021
@pelord pelord deleted the notification branch December 8, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants