-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*) Wfs add param queryFormatAsWms + Workspace new query param #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josee666
changed the title
feat(*) Wfs add param query format as wms
feat(*) Wfs add param queryFormatAsWms + Workspace new query param
Feb 28, 2022
PhilippeLafreniere18
requested changes
Mar 4, 2022
packages/geo/src/lib/datasource/shared/datasources/wfs-datasource.interface.ts
Outdated
Show resolved
Hide resolved
pelord
requested changes
Mar 16, 2022
packages/geo/src/lib/datasource/shared/datasources/wfs-datasource.interface.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/datasource/shared/datasources/wfs-datasource.interface.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/datasource/shared/datasources/wfs-datasource.interface.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/workspace/workspace-updator/workspace-updator.directive.ts
Outdated
Show resolved
Hide resolved
PhilippeLafreniere18
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*In IGO2 assemblage, need to be test with:
pr: infra-geo-ouverte/igo2#748
What is the current behavior?
infra-geo-ouverte/igo2#634
What is the new behavior?
for layer with WMS and WFS, new param
"queryFormatAsWms": true
add in paramsWFS
When is true on query in wfs resolution the getFeatureInfo is done in wms in same format
workspace new param query options:
"workspace": {
"queryOptions": {
"mapQueryOnOpenTab": false,
"tabQuery": false
}
when is false, no query panel info is presente to user when click in attribut table or in map when wks table is open
config exemple to test in assemblage
{
"title": "FEU WMS-WFS",
"visible": true,
"workspace": {
"enabled": true,
"maxResolution": 10,
"queryOptions": {
"mapQueryOnOpenTab": false,
"tabQuery": false
}
},
"metadata": {
"extern": true
},
"sourceOptions": {
"crossOrigin": "anonymous",
"queryable": true,
"queryFormat": "html",
"queryHtmlTarget": "iframe",
"type": "wms",
"optionsFromCapabilities": true,
"url": "/ws/mffpecofor.fcgi",
"params": {
"layers": "ca_feux_close_scale",
"version": "1.3.0"
},
"urlWfs": "/ws/mffpecofor.fcgi",
"paramsWFS": {
"featureTypes": "ca_feux_close_scale",
"fieldNameGeometry": "the_geom",
"maxFeatures": 3000,
"version": "2.0.0",
"queryFormatAsWms": true
}
}
},
{
"title": "Photo(WFS-WMS) queryWMS, Workspace:NoQuery",
"visible": true,
"id": "test",
"workspace": {
"enabled": true,
"maxResolution": 300,
"queryOptions": {
"mapQueryOnOpenTab": false,
"tabQuery": false
}
},
"sourceOptions": {
"queryable": true,
"queryTitle": "test",
"crossOrigin": "anonymous",
"queryFormat": "htmlgml2",
"queryHtmlTarget": "iframe",
"type": "wms",
"optionsFromCapabilities": true,
"url": "/ws/mffpecofor.fcgi",
"params": {
"layers": "nord_photo_oblique",
"version": "1.3.0"
},
"urlWfs": "/ws/mffpecofor.fcgi",
"paramsWFS": {
"featureTypes": "nord_photo_oblique",
"maxFeatures": 1000,
"version": "2.0.0",
"queryFormatAsWms": false
},
"sourceFields": [
{"name": "LATITUDE", "alias": "lat"},
{"name": "LONGITUDE", "alias": "lon"},
{"name": "NOM_PHOTO", "alias": "nom"}
]
}
}
Does this PR introduce a breaking change? (check one with "x")