Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edition-workspace): allow layer edition from new edition workspace #996

merged 125 commits into from Mar 29, 2022


Copy link

@PhilippeLafreniere18 PhilippeLafreniere18 commented Feb 23, 2022

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
No layer edition tool is provided

What is the new behavior?
Layer can now be edited from an edition workspace component

It also provide :

  • relations options on sourceFields, allow to link two or more workspace by an icon -> change workspace (3fdb65a)
  • tooltip on header cell of column (53d7f96)
  • workspace page size options from geoworkspace options config (2253764)
  • Allow wfs layer to be added to the map even if workspace enabled is false (9bbbaa3)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Might have an impact on wms/wfs/feature workspace and other entity table, needs testing

@PhilippeLafreniere18 PhilippeLafreniere18 marked this pull request as ready for review March 24, 2022 21:51
@pelord pelord added this to In progress in IGO2 - Roadmap V1.11 via automation Mar 25, 2022
@PhilippeLafreniere18 PhilippeLafreniere18 merged commit c4ddfc6 into next Mar 29, 2022
IGO2 - Roadmap V1.11 automation moved this from In progress to Done Mar 29, 2022
@pelord pelord deleted the editionTool branch March 30, 2022 15:10
cbourget pushed a commit that referenced this pull request Mar 21, 2023
…ce (#996)

* feat(edition-workspace): add edition workspace

* optional attribute type


* feat(workspace): add edition workspace

* feat(edition-workspace): delete feature function with dialog

* feat(edition-workspace): WIP, add / delete feature


* Edition WIP



* Merge


* WIP edition



* WIP fix change workspace


* Fix onClick in cancelEdit

* add new query param - workspace and combine wmsWfs

* lint correct

* lint

* WIP (fix boolean return to 0 and form value change on cancel)

* Merge with editionToolMike

* WIP fix Icon display and click, cancelEdit


* WIP apply css on input

* feat(edition): add draw control to add feature

* WIP Fix lost focus when table edition is active

* WIP Fix enableEdit

* fix(entity-table): fix double click on button

* WIP Fix cancel edit

* fix(entity-table): fix integer column type input

* add feature call + zoom to extent on draw

* fix(input/workspace): get input value and cancel new feature

* fix(query) query on an imported layer

* fix(query) change variable name to avoid confusion with 'queryFeatures'

* fix(edition-workspace): fix add feature cancel

* fix(workspace): fix maximize

* WIP fix temp geometry post/patch lon/lat

* WIP Fix single click button bug whit input focus out

* fix(edition): fix edition css mode + addFeature refresh

* WIP rollback mousedown button

* lint + version 1

* fix(edition): refresh dataSource after delete

* delete non necessary code

* fix(edition-workspace): button double click/modify refresh

* WIP combobox integration

* WIP fix checkbox

* fix/feat(edition): fix combobox value, disappearing draw, add feature with no draw

* WIP convert number to bool


* Merge

* Fix add feature + list column type/Change in map extent condition for non draw added feature

* fix(edition-table): fix combobox and boolean value

* feat(edition): phase 2 (filter store for add, add feature with no geometry

* lint

* feat(edition-table): * if mandatory is true

* fix(edition): insert feature in store only when drawing is added

* Add column validation before Save


* lint

* WIP Fix update domainValue
Fix mandatory boolean true to validate

* lint

* fix(edition): refresh relations on delete

* lint

* fix(validation): exclude minValue and maxValue from error

* feat(edition-table): add autocomplete input option

* feat(edition): allow to move entity with modify interaction

* feat(edition): add modify style

* add headers parameter for layer
add list sanitizer for transaction

* Fix exclude empty list sanitize

* ui/refactor(edition): increase autocomplete width + lint

* feat(edition): allow date type input

* Ajuster le format de la date dans le datepicker

* add step parameter for number input

* Fix dropdown if value is null don't do toLowerCase

* fix(edition): fix date input value / fix wfs refresh for workspace attriute

* revert package-lock version bad commit

* lint

* feat(edition): check minValue and maxValue validation

* feat(edition): add custom error message check

* feat(edition): disable workspace switch when adding entity

* fix(edition): check if adding is false before activate workspace relations

* feat(workspace): allow paginator options config from geoWorkspaceOptions

* fix/refactor(edition): fix modify relation refresh / clean codeand unuse variables

* fix/feat(edition): fix geometry problem / refresh relations domain value

* feat(workspace): add relations to any kind of workspace

* style(in-map-extent): remove unecessary code

* fix/feat(edition): don't send property if readonly / allow tooltip on header cell

* fix(edition): disable formControl if readonly, fix validation presence

* fix(edition): fix url if no baseUrl

* fix(edition): disabled button when loading is true

* feat(wms-workspace): add wfs link layer even if workspace is defined but not enabled

* Fix with next

* lint

* Minor typo

* fix(workspace): fix workspace button

* fix(wms-workspace): fix enabled override

* chore(geo): umd module ids

Co-authored-by: Michael Lane <>
Co-authored-by: Josée Martel <>
Co-authored-by: Marc-André Trottier <>
Co-authored-by: Pierre-Étienne Lord <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No open projects

Successfully merging this pull request may close these issues.

None yet

3 participants