feat(portal) Wks add button to zoom on selected feature #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2022 16:29
PhilippeLafreniere18
requested changes
Jun 8, 2022
Contributor
PhilippeLafreniere18
left a comment
PhilippeLafreniere18
left a comment
There was a problem hiding this comment.
Works fine for me ! I think it miss the "padding top: 5px" to make sure the button is aligned with the others.
pelord
requested changes
Jun 10, 2022
| olFeaturesSelected.push(localOlFeature); | ||
| } | ||
| if (this.map.viewController.padding[2] === 0) { | ||
| this.map.viewController.setPadding({bottom: 280}); |
Member
There was a problem hiding this comment.
1-C,est risqué pas mal.. faudrait trouver un moyen moins hardcodé
2-Faudrait trouver un moyen de remettre la valeur d'origine après la déselection....
pelord
approved these changes
Jun 14, 2022
PhilippeLafreniere18
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(workspaceState) add method workspaceSelection igo2-lib#1066
#751
What is the new behavior?
add button in wks to zoom on selected feature
Does this PR introduce a breaking change? (check one with "x")