Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] empty namespaces in config file ignores all events #157

Closed
codenio opened this issue Aug 17, 2019 · 1 comment
Closed

[BUG] empty namespaces in config file ignores all events #157

codenio opened this issue Aug 17, 2019 · 1 comment
Labels
Milestone

Comments

@codenio
Copy link
Contributor

@codenio codenio commented Aug 17, 2019

Describe the bug
leaving the Resources.Namespaces empty in the config file ignores all event notifs for the resource

botkube/config.yaml

Lines 2 to 5 in 72f2f19

resources:
- name: pod # Name of the resources e.g pod, deployment, ingress, etc.
namespaces: # List of namespaces, "all" will watch all the namespaces
- all

To Reproduce
Steps to reproduce the behavior:

  1. Make Resources.Namespaces of a resource as empty
  2. Start Botkube server
  3. Trigger an event for the resource
  4. See that all events related to the resources are ignored

Expected behavior
leaving the namespaces empty, should watch the default namespace

@codenio codenio added the bug label Aug 17, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Aug 17, 2019

This is found to be expected behavior.
Hence closing this Issue.

@codenio codenio closed this Aug 17, 2019
@sanketsudake sanketsudake added this to the v0.9.0 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants