Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run as non-root #161

Closed
rajinator opened this issue Aug 18, 2019 · 2 comments · Fixed by #168
Closed

Run as non-root #161

rajinator opened this issue Aug 18, 2019 · 2 comments · Fixed by #168
Milestone

Comments

@rajinator
Copy link
Contributor

@rajinator rajinator commented Aug 18, 2019

Is your feature request related to a problem? Please describe.
Currently the container runs as root, which is not ideal for security.

kubectl exec -it -n botkube botkube-597bc97cdf-pqx6v sh
/ # id
uid=0(root) gid=0(root) groups=0(root),1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel),11(floppy),20(dialout),26(tape),27(video)
/ # whoami
root

Describe the solution you'd like
For a more secure deployment, make changes to Dockerfile, k8s manifest and helm chart, to run as non root.

Additional context
Might add a PR with example code soon.

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Sep 1, 2019

@aananthraj please let others know if you have picked up or want to work on an issue to avoid work duplication 🙂 You can assign task to yourself that will help in tracking the issue

@codenio
Copy link
Contributor

@codenio codenio commented Sep 1, 2019

Sure, will let others know 👍

You can assign task to yourself that will help in tracking the issue.

I guess I dont have enough privileges to assign an issue to myself 😅.
Will ask one of you to do so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants