Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skip field BotKube Event #63

Closed
sanketsudake opened this issue Mar 26, 2019 · 1 comment
Closed

Add Skip field BotKube Event #63

sanketsudake opened this issue Mar 26, 2019 · 1 comment

Comments

@sanketsudake
Copy link
Member

@sanketsudake sanketsudake commented Mar 26, 2019

Describe the bug
We need to add Skip field in BotKube struct so that if any of filters ask to skip the reporting of the event to slack, we should be able to that.
Filter Engine should not pass event further if it observes Skip fieldset.

Expected behaviour
Filter sets Skip field in BotKube Struct, FilterEngine should stop processing event.

Additional context
We had a use case where a BotKube user reported a lot of pods where getting created through CronJob and he was not interested in Create/Delete events for them. The filter could not allow skipping of events currently.

@sanketsudake sanketsudake changed the title [BUG] Add Skip field BotKube Event [Enhancement] Add Skip field BotKube Event Mar 26, 2019
@sanketsudake sanketsudake changed the title [Enhancement] Add Skip field BotKube Event Add Skip field BotKube Event Mar 26, 2019
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Mar 28, 2019

Fixed with #67

@PrasadG193 PrasadG193 closed this Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants