Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Do not dump auth token in `@BotKube notifier showconfig` command response #64

Closed
PrasadG193 opened this issue Mar 26, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@PrasadG193
Copy link
Member

commented Mar 26, 2019

Describe the bug
As of now, @BotKube notifier showconfig command responds with BotKube config containing BotKube auth Token. We should hide the token in config body

To Reproduce
@BotKube notifier showconfig

Expected behavior
BotKube auth token should not be accessible via command responses as will as logs of the BotKube backend

@PrasadG193 PrasadG193 added the bug label Mar 26, 2019

@PrasadG193 PrasadG193 changed the title [BUG] Do not dump BotKube token in `@BotKube notifier showconfig` command response [BUG] Do not dump auth token in `@BotKube notifier showconfig` command response Mar 26, 2019

@PrasadG193

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Fixed with #65

@PrasadG193 PrasadG193 closed this Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.